Stop the completion tests from failing randomly

* windows compatible warning match pattern for erlc

.appveyor.yml

@@ -5,11 +5,6 @@ clone_depth: 10
 # Use the directory C:\testplugin so test directories will mostly work.
 clone_folder: C:\testplugin
 
-branches:
-  only:
-    - master
-    - /v\d+\.\d+\.(x|\d+)/
-
 # Cache the vim and vader directories between builds.
 cache:
   - C:\vim -> .appveyor.yml
@@ -19,9 +14,6 @@ init:
   # Stop git from changing newlines
   - git config --global core.autocrlf input
 
-# NOTE: If you change the Vim or Vader versions here, please also update the
-# instructions for running tests on Windows in ale-development.txt
-
 install:
   # Download and unpack Vim
   - ps: >-

.gitattributes

@@ -2,7 +2,6 @@
 /CODE_OF_CONDUCT.md export-ignore
 /CONTRIBUTING.md export-ignore
 /Dockerfile export-ignore
-/ISSUE_TEMPLATE export-ignore
 /ISSUE_TEMPLATE.md export-ignore
 /Makefile export-ignore
 /PULL_REQUEST_TEMPLATE.md export-ignore

.github/CONTRIBUTING.md

@@ -1,25 +0,0 @@
-## Guidelines
-
-Have fun, and work on whatever floats your boat. Take It Easy :tm:.
-
-For help with contributing to ALE, see `:help ale-development` in Vim, or view
-the help file online [here](/doc/ale-development.txt).
-
-## Creating Issues
-
-Before creating any issues, please look through the current list of issues and
-pull requests, and ensure that the issue hasn't already been reported. If an
-issue has already been reported, but you have some new insight, please add
-a comment to the existing issue.
-
-Please read the FAQ in the README before creating any issues. A feature
-you desire may already exist and be documented, or the FAQ might explain
-how to solve a problem you have already.
-
-Please try and describe any issues reported with as much detail as you can
-provide about your Vim version, the linter you were trying to run, your
-operating system, or any other information you think might be helpful.
-
-Please describe your issue in clear, grammatically correct, and easy to
-understand English. You are more likely to see an issue resolved if others
-can understand you.

.github/ISSUE_TEMPLATE/config.yml

@@ -1,6 +0,0 @@
----
-blank_issues_enabled: false
-contact_links:
-  - name: Ask for Help
-    url: https://github.com/dense-analysis/ale/discussions/new?category=q-a-ask-for-help-with-problems
-    about: Ask for Help in ALE Discussions

.github/ISSUE_TEMPLATE/report-a-bug.md

@@ -1,48 +0,0 @@
----
-name: Report a bug
-labels: bug
-about: Report a bug with ALE.
-
----
-
-<!--
-  This is the template for reporting ALE bugs. Make sure you try updating ALE
-  to a more recent version before reporting a bug. Look through existing bug
-  reports for similar issues before reporting a new one. Don't leave comments
-  about new bugs in the comment section for old issues.
-
-  Make sure to try disabling other plugins and trying to repeat your bug before
-  reporting it in ALE. Some times problems can arise when two plugins are used
-  together, but often your issues might be problems with other plugins.
--->
-
-## Information
-
-**VIM version**
-
-<!-- Paste just the first two lines of :version here. -->
-
-Operating System: <!-- Describe your operating system version. -->
-
-## What went wrong
-
-<!-- Describe what went wrong here. Be specific. -->
-
-Something went wrong in specifically this place, and I also searched through both open and closed issues for the same problem before reporting a bug here.
-
-Are you having trouble configuring ALE? Try asking for help on [Stack Exchange](https://vi.stackexchange.com/) or perhaps on [Reddit](https://www.reddit.com/r/vim/) instead. The GitHub issue tracker should be used for reporting bugs or asking for new features.
-
-## Reproducing the bug
-
-<!-- Write a list of steps below. -->
-
-1. I did this.
-2. Then this happened.
-
-### :ALEInfo
-<details>
-  <summary>Expand</summary>
-  <!-- Paste the output of :ALEInfo here. Try :ALEInfoToClipboard -->
-  <!-- Make sure to run :ALEInfo from the buffer where the bug occurred. -->
-  <!-- Read the output. You might figure out what went wrong yourself. -->
-</details>

.github/ISSUE_TEMPLATE/suggest-a-new-linter-or-fixer.md

@@ -1,21 +0,0 @@
----
-name: Suggest a new linter or fixer
-labels: new tool
-about: Suggest a new tool ALE can officially integrate with.
-
----
-
-<!--
-  Write "Add support for foobar" as the issue title, or similar.
-
-  Fill out the details below.
--->
-
-**Name:** foobar
-**URL:** https://foo.bar.com
-
-<!--
-  Write a description of the tool, and add any other information you think might
-  be helpful. Consider creating a pull request to add support for the tool
-  yourself.
--->

.github/ISSUE_TEMPLATE/suggest-an-improvement.md

@@ -1,8 +0,0 @@
----
-name: Suggest an improvement
-labels: enhancement
-about: Suggest some way to improve ALE, or add a new feature.
-
----
-
-<!-- There's no fixed format for feature requests. Just add your thoughts. -->

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,13 +0,0 @@
-<!--
-Before creating a pull request, do the following.
-
-* Read the Contributing guide linked above first.
-* Read the documentation that comes with ALE with `:help ale-dev`.
-
-Have fun!
--->
-
-Where are the tests? Have you added tests? Have you updated the tests? Read the
-comment above and the documentation referenced in it first. Write tests!
-
-Seriously, read `:help ale-dev` and write tests.

.github/stale.yml

@@ -1,17 +0,0 @@
----
-# This configuration closes stale PRs after 56 + 7 days.
-# That's 8 weeks until stale bot complains, and a week until it closes a PR.
-# Issues in ALE are never, ever stale. They are either resolved or not.
-only: pulls
-daysUntilStale: 56
-daysUntilClose: 7
-exemptLabels: []
-staleLabel: stale
-markComment: >
-  This pull request has been automatically marked as stale because it has not
-  been updated recently. Make sure to write tests and document your changes.
-  See `:help ale-dev` for information on writing tests.
-
-  If your pull request is good to merge, bother w0rp or another maintainer
-  again, and get them to merge it.
-closeComment: false

.github/workflows/main.yml

@@ -1,37 +0,0 @@
----
-name: CI
-on:  # yamllint disable-line rule:truthy
-  push:
-    branches: [ master ]  # yamllint disable-line rule:brackets
-    tags:
-      - v[0-9]+.[0-9]+.x
-      - v[0-9]+.[0-9]+.[0-9]+
-  pull_request:
-    branches: [ master ]  # yamllint disable-line rule:brackets
-
-jobs:
-  build_image:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v2
-      - name: Build docker run image
-        shell: bash
-        env:
-          DOCKER_HUB_USER: ${{ secrets.DOCKER_HUB_USER }}
-          DOCKER_HUB_PASS: ${{ secrets.DOCKER_HUB_PASS }}
-        run: ./run-tests --build-image
-  test_ale:
-    needs: build_image
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        vim-version:
-          - '--vim-80-only'
-          - '--vim-82-only'
-          - '--neovim-02-only'
-          - '--neovim-07-only'
-          - '--linters-only'
-    steps:
-      - uses: actions/checkout@v2
-      - name: Run tests
-        run: ./run-tests -v ${{ matrix.vim-version }}

.gitignore

@@ -1,12 +1,6 @@
+/init.vim
+/doc/tags
+.*
 !.editorconfig
 *.obj
-*.pyc
-# Ignore all hidden files everywhere.
-# Use `git add -f` to add hidden files.
-.*
-/doc/tags
-/init.vim
-/test/ale-info-test-file
-/vader_output
-__pycache__
 tags

.travis.yml

@@ -0,0 +1,7 @@
+---
+sudo: required
+services:
+    - docker
+language: python
+script: |
+    ./run-tests

.vintrc.yaml

@@ -1,5 +0,0 @@
-policies:
-  # Disable a violation that is thrown randomly for reasons I still
-  # do not understand.
-  ProhibitMissingScriptEncoding:
-    enabled: false

CONTRIBUTING.md

@@ -0,0 +1,173 @@
+# Contributing to ALE
+
+1. [Guidelines](#guidelines)
+2. [Creating Issues](#issues)
+3. [Creating Pull Requests](#pull-requests)
+    1. [Adding a New Linter](#adding-a-new-linter)
+    2. [Adding New Options](#adding-new-options)
+4. [Writing Documentation](#writing-documentation)
+    1. [Documenting New Linters](#documenting-new-linters)
+    2. [Editing the Online Documentation](#editing-online-documentation)
+    3. [Documenting Linter Options](#documenting-linter-options)
+5. [In Case of Busses](#in-case-of-busses)
+
+<a name="guidelines"></a>
+
+## 1. Guidelines
+
+Have fun, and work on whatever floats your boat. Take It Easy :tm:.
+
+Don't forget to **write documentation** for whatever it is you are doing.
+See the ["Writing Documentation"](#writing-documentation) section.
+
+Remember to write Vader tests for most of the code you write. You can look at
+existing Vader tests in the `test` directory for examples.
+
+When writing code, follow the [Google Vimscript Style
+Guide](https://google.github.io/styleguide/vimscriptguide.xml), and run `vint
+-s` on your files to check for most of what the guide mentions and more. If you
+install this plugin (ALE) and install [Vint](https://github.com/Kuniwak/vint), it
+will check your code while you type.
+
+<a name="issues"></a>
+
+## 2. Creating Issues
+
+Before creating any issues, please look through the current list of issues and
+pull requests, and ensure that the issue hasn't already been reported. If an
+issue has already been reported, but you have some new insight, please add
+a comment to the existing issue.
+
+Please read the FAQ in the README before creating any issues. A feature
+you desire may already exist and be documented, or the FAQ might explain
+how to solve a problem you have already.
+
+Please try and describe any issues reported with as much detail as you can
+provide about your Vim version, the linter you were trying to run, your
+operating system, or any other information you think might be helpful.
+
+Please describe your issue in clear, grammatically correct, and easy to
+understand English. You are more likely to see an issue resolved if others
+can understand you.
+
+<a name="pull-requests"></a>
+
+## 3. Creating Pull Requests
+
+For code you write, make sure to credit yourself at the top of files you add,
+and probably those you modify. You can write some comments at the top of your
+VIM files.
+
+```vim
+" Author: John Smith <john.smith@gmail.com>
+" Description: This file adds support for awesomelinter for the best language ever.
+```
+
+If you want to credit multiple authors, you can comma separate them.
+
+```vim
+" Author: John Smith <john.smith@gmail.com>, Jane Doe <https://jane-doe.info>
+```
+
+<a name="adding-a-new-linter"></a>
+
+### 3.i. Adding a New Linter
+
+If you add a new linter, look for existing handlers first in the
+[handlers](autoload/ale/handlers) directory. One of the handlers there may
+already be able to handle your lines of output. If you find that your new
+linter replicates an existing error handler, consider pulling it up into the
+[handlers](autoload/ale/handlers) directory, and use the generic handler in
+both places.
+
+When you add a linter, make sure the language for the linter and the linter
+itself are present in the table in the [README.md](README.md) file and in the
+Vim [help file](doc/ale.txt). The programs and linters should be sorted
+alphabetically in the table and list.
+
+<a name="adding-new-options"></a>
+
+### 3.ii. Adding New Options
+
+If you add new options to the plugin, make sure to document those new options
+in the [README.md](README.md) file, and also in the [help file](doc/ale.txt).
+Follow the format of other options in each. Global options should appear in the
+README file, and in the relevant section in the help file. Options specific
+to a particular linter should appear in the section for that linter.
+
+Linter options for customizing general argument lists should be named
+`g:ale_<filetype>_<linter>_options`, so that all linters can have similar
+global variable names.
+
+Any options for linters should be set to some default value so it is always
+easy to see what the default is with `:echo g:ale...`.
+
+<a name="writing-documentation"></a>
+
+## 4. Writing Documentation
+
+If you are adding new linters, changing the API, adding new options, etc., you
+_must_ write some documentation describing it in the `doc/ale.txt` file.  New
+linters _must_ be added to the `README.md` file too, so other users can get a
+quick overview of the supported tools.
+
+<a name="documenting-new-linters"></a>
+
+### 4.i Documenting New Linters
+
+If you add a new linter to the project, edit the table in the `README.md` file,
+and edit the list of linters at the top of the `doc/ale.txt` file. The linters
+should be sorted vertically in lexicographic (alphabetical) order by the
+programming language name or filetype, and the tools for each language should
+be sorted in lexicographic order horizontally. Sorting in this manner is a fair
+manner of presenting all of the information in an easy to scan way, without
+giving some unfair preference to any particular tool or language.
+
+<a name="editing-online-documentation"></a>
+
+### 4.ii Editing the Online Documentation
+
+The "online documentation" file used for this project lives in `doc/ale.txt`.
+This is the file used for generating `:help` text inside Vim itself. There are
+some guidelines to follow for this file.
+
+1. Keep all text within a column size of 79 characters, inclusive.
+2. Open a section with 79 `=` or `-` characters, for headings and subheadings.
+3. Sections should have a _single_ blank line before or after.
+4. Between descriptions of variables/functions/commands, use _two_ blank lines.
+5. Up-indent the description of a variable/function/command by two spaces.
+6. Place tags at the ends of lines, with the final characters on column 79.
+   All of the tags should line up perfectly on the same column as you scan
+   down through the document.
+7. Keep the table of contents balanced so the longest tag link ends on column
+   79, and so all links line up perfectly on their first character, on the
+   left.
+
+<a name="documenting-linter-options"></a>
+
+### 4.iii Documenting Linter Options
+
+For documenting new linter options, please add a new sub-section under the
+"Linter Specific Options" section describing all of the global options added
+for each linter, and what the default values of the options are. All global
+options for linters should be set to some default value. This will allow users
+to look up the default value easily by typing `:echo g:ale_...`.
+
+<a name="in-case-of-busses"></a>
+
+## 5. In Case of Busses
+
+Should the principal author of the ALE project and all collaborators with the
+required access needed to properly administrate the project on GitHub or any
+other website either perish or disappear, whether by tragic traffic accident
+or government abduction, etc., action should be taken to ensure that the
+project continues. If no one is left to administer the project where it is
+hosted, please fork the project and nominate someone capable to administer it.
+Preferably, in such an event, a single fork of the project will replace the
+original, and life will go on, except the life of whoever vanished, because
+then they will probably be dead.
+
+Should w0rp suddenly disappear, then he was probably killed in a traffic
+accident, or the government finally decided to kill him and make it look like
+suicide. In the latter event, please subvert said government and restore
+order to the universe, and ensure peace for mankind.

Dockerfile

@@ -1,27 +1,18 @@
-FROM testbed/vim:20
+FROM tweekmonster/vim-testbed:latest
 
 RUN install_vim -tag v8.0.0027 -build \
-                -tag v8.2.4693 -build \
-                -tag neovim:v0.2.0 -build \
-                -tag neovim:v0.7.0 -build
+                -tag neovim:v0.1.7 -build
 
 ENV PACKAGES="\
     bash \
     git \
-    python2 \
-    python3 \
-    py3-pip \
-    grep \
-    sed \
+    python \
+    py-pip \
 "
 RUN apk --update add $PACKAGES && \
     rm -rf /var/cache/apk/* /tmp/* /var/tmp/*
 
-RUN pip install vim-vint==0.3.21
+RUN pip install vim-vint==0.3.9
 
 RUN git clone https://github.com/junegunn/vader.vim vader && \
     cd vader && git checkout c6243dd81c98350df4dec608fa972df98fa2a3af
-
-ARG GIT_VERSION
-LABEL Version=${GIT_VERSION}
-LABEL Name=denseanalysis/ale

ISSUE_TEMPLATE.md

@@ -0,0 +1,8 @@
+<!--
+For bugs, paste output from your clipboard after running :ALEInfoToClipboard
+here. If that doesn't work for some reason, try running :ALEInfo and copying
+the output from that here instead. If everything is broken, run around in
+circles and scream.
+
+Whatever the case, describe the your issue here.
+-->

LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2016-2020, w0rp <devw0rp@gmail.com>
+Copyright (c) 2016-2017, w0rp <devw0rp@gmail.com>
 All rights reserved.
 
 Redistribution and use in source and binary forms, with or without

PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,21 @@
+<!--
+READ THIS: Before creating a pull request, please consider the following first.
+
+* The most important thing you can do is write tests. Code without tests
+  probably doesn't work, and will almost certainly stop working later on. Pull
+  requests without tests probably won't be accepted, although there are some
+  exceptions.
+* Read the Contributing guide linked above first.
+* If you are adding a new linter, remember to update the README.md file and
+  doc/ale.txt first.
+* If you add or modify a function for converting error lines into loclist items
+  that ALE can work with, please add Vader tests for them. Look at existing
+  tests in the test/handler directory, etc.
+* If you add or modify a function for computing a command line string for
+  running a command, please add Vader tests for that.
+* Generally try and cover anything with Vader tests, although some things just
+  can't be tested with Vader, or at least they can be hard to test. Consider
+  breaking up your code so that some parts can be tested, and generally open up
+  a discussion about it.
+* Have fun!
+-->

after/plugin/ale.vim

@@ -0,0 +1,37 @@
+" Author: w0rp <devw0rp@gmail.com>
+" Description: Follow-up checks for the plugin: warn about conflicting plugins.
+
+" A flag for ensuring that this is not run more than one time.
+if exists('g:loaded_ale_after')
+    finish
+endif
+
+" Set the flag so this file is not run more than one time.
+let g:loaded_ale_after = 1
+
+" Check if the flag is available and set to 0 to disable checking for and
+" emitting conflicting plugin warnings.
+if exists('g:ale_emit_conflict_warnings') && !g:ale_emit_conflict_warnings
+    finish
+endif
+
+" Conflicting Plugins Checks
+
+function! s:GetConflictingPluginWarning(plugin_name) abort
+    return 'ALE conflicts with ' . a:plugin_name
+    \   . '. Uninstall it, or disable this warning with '
+    \   . '`let g:ale_emit_conflict_warnings = 0` in your vimrc file, '
+    \   . '*before* plugins are loaded.'
+endfunction
+
+if exists('g:loaded_syntastic_plugin')
+    throw s:GetConflictingPluginWarning('Syntastic')
+endif
+
+if exists('g:loaded_neomake')
+    throw s:GetConflictingPluginWarning('Neomake')
+endif
+
+if exists('g:loaded_validator_plugin')
+    throw s:GetConflictingPluginWarning('Validator')
+endif

ale_linters/ada/adals.vim

@@ -1,26 +0,0 @@
-" Author: Bartek Jasicki http://github.com/thindil
-" Description: Support for Ada Language Server
-
-call ale#Set('ada_adals_executable', 'ada_language_server')
-call ale#Set('ada_adals_project', 'default.gpr')
-call ale#Set('ada_adals_encoding', 'utf-8')
-
-function! ale_linters#ada#adals#GetAdaLSConfig(buffer) abort
-    return {
-    \   'ada.projectFile': ale#Var(a:buffer, 'ada_adals_project'),
-    \   'ada.defaultCharset': ale#Var(a:buffer, 'ada_adals_encoding')
-    \}
-endfunction
-
-function! ale_linters#ada#adals#GetRootDirectory(buffer) abort
-    return fnamemodify(bufname(a:buffer), ':p:h')
-endfunction
-
-call ale#linter#Define('ada', {
-\   'name': 'adals',
-\   'lsp': 'stdio',
-\   'executable': {b -> ale#Var(b, 'ada_adals_executable')},
-\   'command': '%e',
-\   'project_root': function('ale_linters#ada#adals#GetRootDirectory'),
-\   'lsp_config': function('ale_linters#ada#adals#GetAdaLSConfig')
-\})

ale_linters/ada/cspell.vim

@@ -1,5 +0,0 @@
-scriptencoding utf-8
-" Author: David Houston <houstdav000>
-" Description: cspell support for Ada files.
-
-call ale#handlers#cspell#DefineLinter('ada')

ale_linters/ada/gcc.vim

@@ -1,54 +0,0 @@
-" Author: Martino Pilia <martino.pilia@gmail.com>
-" Description: Lint Ada files with GCC
-
-call ale#Set('ada_gcc_executable', 'gcc')
-
-" -gnatwa: activate most optional warnings
-" -gnatq: try semantic analysis even if syntax errors have been found
-call ale#Set('ada_gcc_options', '-gnatwa -gnatq')
-
-function! ale_linters#ada#gcc#GetCommand(buffer) abort
-    " Build a suitable output file name. The output file is specified because
-    " the .ali file may be created even if no code generation is attempted.
-    " The output file name must match the source file name (except for the
-    " extension), so here we cannot use the null file as output.
-    let l:tmp_dir = fnamemodify(ale#command#CreateDirectory(a:buffer), ':p')
-    let l:out_file = l:tmp_dir . fnamemodify(bufname(a:buffer), ':t:r') . '.o'
-
-    " -gnatc: Check syntax and semantics only (no code generation attempted)
-    return '%e -x ada -c -gnatc'
-    \   . ' -o ' . ale#Escape(l:out_file)
-    \   . ' -I %s:h'
-    \   . ale#Pad(ale#Var(a:buffer, 'ada_gcc_options'))
-    \   . ' %t'
-endfunction
-
-" For the message format please refer to:
-"   https://gcc.gnu.org/onlinedocs/gnat_ugn/Output-and-Error-Message-Control.html
-"   https://gcc.gnu.org/onlinedocs/gnat_ugn/Warning-Message-Control.html
-function! ale_linters#ada#gcc#Handle(buffer, lines) abort
-    " Error format: <filename>:<lnum>:<col>: <text>
-    " Warning format: <filename>:<lnum>:<col>: warning: <text>
-    let l:re = '\v(.+):([0-9]+):([0-9]+):\s+(warning:)?\s*(.+)\s*'
-    let l:output = []
-
-    for l:match in ale#util#GetMatches(a:lines, l:re)
-        call add(l:output, {
-        \   'bufnr': a:buffer,
-        \   'lnum': str2nr(l:match[2]),
-        \   'col': str2nr(l:match[3]),
-        \   'type': l:match[4] is# 'warning:' ? 'W' : 'E',
-        \   'text': l:match[5],
-        \})
-    endfor
-
-    return l:output
-endfunction
-
-call ale#linter#Define('ada', {
-\   'name': 'gcc',
-\   'output_stream': 'stderr',
-\   'executable': {b -> ale#Var(b, 'ada_gcc_executable')},
-\   'command': function('ale_linters#ada#gcc#GetCommand'),
-\   'callback': 'ale_linters#ada#gcc#Handle',
-\})

ale_linters/ansible/ansible_lint.vim

@@ -1,13 +1,7 @@
-" Authors: Bjorn Neergaard <bjorn@neersighted.com>, Vytautas Macionis <vytautas.macionis@manomail.de>
+" Author: Bjorn Neergaard <bjorn@neersighted.com>
 " Description: ansible-lint for ansible-yaml files
 
-call ale#Set('ansible_ansible_lint_executable', 'ansible-lint')
-
-function! ale_linters#ansible#ansible_lint#GetExecutable(buffer) abort
-    return ale#Var(a:buffer, 'ansible_ansible_lint_executable')
-endfunction
-
-function! ale_linters#ansible#ansible_lint#Handle(buffer, version, lines) abort
+function! ale_linters#ansible#ansible_lint#Handle(buffer, lines) abort
     for l:line in a:lines[:10]
         if match(l:line, '^Traceback') >= 0
             return [{
@@ -18,111 +12,37 @@ function! ale_linters#ansible#ansible_lint#Handle(buffer, version, lines) abort
         endif
     endfor
 
-    let l:version_group = ale#semver#GTE(a:version, [6, 0, 0]) ? '>=6.0.0' :
-    \                     ale#semver#GTE(a:version, [5, 0, 0]) ? '>=5.0.0' :
-    \                     '<5.0.0'
+    " Matches patterns line the following:
+    "
+    " test.yml:35: [EANSIBLE0002] Trailing whitespace
+    let l:pattern = '\v^([a-zA-Z]?:?[^:]+):(\d+):?(\d+)?: \[?([[:alnum:]]+)\]? (.*)$'
     let l:output = []
 
-    if '>=6.0.0' is# l:version_group
-        let l:error_codes = { 'blocker': 'E', 'critical': 'E', 'major': 'W', 'minor': 'W', 'info': 'I' }
-        let l:linter_issues = json_decode(join(a:lines, ''))
+    for l:match in ale#util#GetMatches(a:lines, l:pattern)
+        let l:code = l:match[4]
 
-        for l:issue in l:linter_issues
-            if ale#path#IsBufferPath(a:buffer, l:issue.location.path)
-                call add(l:output, {
-                \   'lnum': exists('l:issue.location.lines.begin.column') ? l:issue.location.lines.begin.line :
-                \           l:issue.location.lines.begin,
-                \   'col': exists('l:issue.location.lines.begin.column') ? l:issue.location.lines.begin.column : 0,
-                \   'text': l:issue.check_name,
-                \   'detail': l:issue.description,
-                \   'code': l:issue.severity,
-                \   'type': l:error_codes[l:issue.severity],
-                \})
-            endif
-        endfor
-    endif
+        if l:code is# 'EANSIBLE002'
+        \&& !ale#Var(a:buffer, 'warn_about_trailing_whitespace')
+            " Skip warnings for trailing whitespace if the option is off.
+            continue
+        endif
 
-    if '>=5.0.0' is# l:version_group
-        " Matches patterns line the following:
-        "      test.yml:3:148: syntax-check 'var' is not a valid attribute for a Play
-        "      roles/test/tasks/test.yml:8: [package-latest] [VERY_LOW] Package installs should not use latest
-        "      D:\test\tasks\test.yml:8: [package-latest] [VERY_LOW] package installs should not use latest
-        let l:pattern = '\v^(%([a-zA-Z]:)?[^:]+):(\d+):%((\d+):)? %(\[([-[:alnum:]]+)\]) %(\[([_[:alnum:]]+)\]) (.*)$'
-        let l:error_codes = { 'VERY_HIGH': 'E', 'HIGH': 'E', 'MEDIUM': 'W', 'LOW': 'W', 'VERY_LOW': 'W', 'INFO': 'I' }
-
-        for l:match in ale#util#GetMatches(a:lines, l:pattern)
-            if ale#path#IsBufferPath(a:buffer, l:match[1])
-                call add(l:output, {
-                \   'lnum': l:match[2] + 0,
-                \   'col': l:match[3] + 0,
-                \   'text': l:match[6],
-                \   'code': l:match[4],
-                \   'type': l:error_codes[l:match[5]],
-                \})
-            endif
-        endfor
-    endif
-
-    if '<5.0.0' is# l:version_group
-        " Matches patterns line the following:
-        "      test.yml:35: [EANSIBLE0002] Trailing whitespace
-        let l:pattern = '\v^([a-zA-Z]?:?[^:]+):(\d+):?(\d+)?: \[?([[:alnum:]]+)\]? (.*)$'
-
-        for l:match in ale#util#GetMatches(a:lines, l:pattern)
-            let l:code = l:match[4]
-
-            if l:code is# 'EANSIBLE0002'
-            \&& !ale#Var(a:buffer, 'warn_about_trailing_whitespace')
-                " Skip warnings for trailing whitespace if the option is off.
-                continue
-            endif
-
-            if ale#path#IsBufferPath(a:buffer, l:match[1])
-                call add(l:output, {
-                \   'lnum': l:match[2] + 0,
-                \   'col': l:match[3] + 0,
-                \   'text': l:match[5],
-                \   'code': l:code,
-                \   'type': l:code[:0] is# 'E' ? 'E' : 'W',
-                \})
-            endif
-        endfor
-    endif
+        if ale#path#IsBufferPath(a:buffer, l:match[1])
+            call add(l:output, {
+            \   'lnum': l:match[2] + 0,
+            \   'col': l:match[3] + 0,
+            \   'text': l:code . ': ' . l:match[5],
+            \   'type': l:code[:0] is# 'E' ? 'E' : 'W',
+            \})
+        endif
+    endfor
 
     return l:output
 endfunction
 
-function! ale_linters#ansible#ansible_lint#GetCommand(buffer, version) abort
-    let l:commands = {
-    \   '>=6.0.0': '%e --nocolor -f json -x yaml %s',
-    \   '>=5.0.0': '%e --nocolor --parseable-severity -x yaml %s',
-    \   '<5.0.0': '%e --nocolor -p %t'
-    \}
-    let l:command = ale#semver#GTE(a:version, [6, 0]) ? l:commands['>=6.0.0'] :
-    \               ale#semver#GTE(a:version, [5, 0]) ? l:commands['>=5.0.0'] :
-    \               l:commands['<5.0.0']
-
-    return l:command
-endfunction
-
 call ale#linter#Define('ansible', {
-\   'name': 'ansible_lint',
-\   'aliases': ['ansible', 'ansible-lint'],
-\   'executable': function('ale_linters#ansible#ansible_lint#GetExecutable'),
-\   'command': {buffer -> ale#semver#RunWithVersionCheck(
-\       buffer,
-\       ale_linters#ansible#ansible_lint#GetExecutable(buffer),
-\       '%e --version',
-\       function('ale_linters#ansible#ansible_lint#GetCommand'),
-\   )},
-\   'lint_file': 1,
-\   'callback': {buffer, lines -> ale#semver#RunWithVersionCheck(
-\       buffer,
-\       ale_linters#ansible#ansible_lint#GetExecutable(buffer),
-\       '%e --version',
-\       {buffer, version -> ale_linters#ansible#ansible_lint#Handle(
-\           buffer,
-\           l:version,
-\           lines)},
-\   )},
+\   'name': 'ansible',
+\   'executable': 'ansible',
+\   'command': 'ansible-lint -p %t',
+\   'callback': 'ale_linters#ansible#ansible_lint#Handle',
 \})

ale_linters/apiblueprint/drafter.vim

@@ -1,38 +0,0 @@
-" Author: nametake https://nametake.github.io
-" Description: apiblueprint parser
-
-function! ale_linters#apiblueprint#drafter#HandleErrors(buffer, lines) abort
-    " Matches patterns line the following:
-    "
-    " warning: (3)  unable to parse response signature, expected 'response [<HTTP status code>] [(<media type>)]'; line 4, column 3k - line 4, column 22
-    " warning: (10)  message-body asset is expected to be a pre-formatted code block, separate it by a newline and indent every of its line by 12 spaces or 3 tabs; line 30, column 5 - line 30, column 9; line 31, column 9 - line 31, column 14; line 32, column 9 - line 32, column 14
-    let l:pattern = '\(^.*\): (\d\+)  \(.\{-\}\); line \(\d\+\), column \(\d\+\) - line \d\+, column \d\+\(.*; line \d\+, column \d\+ - line \(\d\+\), column \(\d\+\)\)\{-\}$'
-    let l:output = []
-
-    for l:match in ale#util#GetMatches(a:lines[2:], l:pattern)
-        let l:item = {
-        \   'type': l:match[1] is# 'warning' ? 'W' : 'E',
-        \   'text': l:match[2],
-        \   'lnum': l:match[3] + 0,
-        \   'col': l:match[4] + 0,
-        \}
-
-        if l:match[5] isnot# ''
-            let l:item.end_lnum = l:match[6] + 0
-            let l:item.end_col = l:match[7] + 0
-        endif
-
-        call add(l:output, l:item)
-    endfor
-
-    return l:output
-endfunction
-
-
-call ale#linter#Define('apiblueprint', {
-\   'name': 'drafter',
-\   'output_stream': 'stderr',
-\   'executable': 'drafter',
-\   'command': 'drafter --use-line-num --validate',
-\   'callback': 'ale_linters#apiblueprint#drafter#HandleErrors',
-\})

ale_linters/apkbuild/apkbuild_lint.vim

@@ -1,12 +0,0 @@
-" Author: Leo <thinkabit.ukim@gmail.com>
-" Description: apkbuild-lint from atools linter for APKBUILDs
-
-call ale#Set('apkbuild_apkbuild_lint_executable', 'apkbuild-lint')
-
-call ale#linter#Define('apkbuild', {
-\   'name': 'apkbuild_lint',
-\   'output_stream': 'stdout',
-\   'executable': {b -> ale#Var(b, 'apkbuild_apkbuild_lint_executable')},
-\   'command': '%e %t',
-\   'callback': 'ale#handlers#atools#Handle',
-\})

ale_linters/apkbuild/secfixes_check.vim

@@ -1,12 +0,0 @@
-" Author: Leo <thinkabit.ukim@gmail.com>
-" Description: secfixes-check from atools linter for APKBUILDs
-
-call ale#Set('apkbuild_secfixes_check_executable', 'secfixes-check')
-
-call ale#linter#Define('apkbuild', {
-\   'name': 'secfixes_check',
-\   'output_stream': 'stdout',
-\   'executable': {b -> ale#Var(b, 'apkbuild_secfixes_check_executable')},
-\   'command': '%e %t',
-\   'callback': 'ale#handlers#atools#Handle',
-\})

ale_linters/asciidoc/alex.vim

@@ -1,4 +0,0 @@
-" Author: Johannes Wienke <languitar@semipol.de>
-" Description: alex for asciidoc files
-
-call ale#handlers#alex#DefineLinter('asciidoc', '--text')

ale_linters/asciidoc/cspell.vim

@@ -1,5 +0,0 @@
-scriptencoding utf-8
-" Author: David Houston <houstdav000>
-" Description: cspell support for ASCIIDoc files.
-
-call ale#handlers#cspell#DefineLinter('asciidoc')

ale_linters/asciidoc/languagetool.vim

@@ -1,5 +0,0 @@
-" Author: Horacio Sanson (hsanson [ät] gmail.com)
-" Description: languagetool for asciidoc files, copied from markdown.
-
-
-call ale#handlers#languagetool#DefineLinter('asciidoc')

ale_linters/asciidoc/redpen.vim

@@ -1,9 +0,0 @@
-" Author: rhysd https://rhysd.github.io
-" Description: Redpen, a proofreading tool (http://redpen.cc)
-
-call ale#linter#Define('asciidoc', {
-\   'name': 'redpen',
-\   'executable': 'redpen',
-\   'command': 'redpen -f asciidoc -r json %t',
-\   'callback': 'ale#handlers#redpen#HandleRedpenOutput',
-\})

ale_linters/asciidoc/textlint.vim

@@ -1,9 +0,0 @@
-" Author: TANIGUCHI Masaya <ta2gch@gmail.com>
-" Description: textlint for AsciiDoc files
-
-call ale#linter#Define('asciidoc', {
-\   'name': 'textlint',
-\   'executable': function('ale#handlers#textlint#GetExecutable'),
-\   'command': function('ale#handlers#textlint#GetCommand'),
-\   'callback': 'ale#handlers#textlint#HandleTextlintOutput',
-\})

ale_linters/asciidoc/vale.vim

@@ -1,9 +0,0 @@
-" Author: Jeff Kreeftmeijer https://github.com/jeffkreeftmeijer
-" Description: vale for AsciiDoc files
-
-call ale#linter#Define('asciidoc', {
-\   'name': 'vale',
-\   'executable': 'vale',
-\   'command': 'vale --output=line %t',
-\   'callback': 'ale#handlers#unix#HandleAsWarning',
-\})

ale_linters/asciidoc/writegood.vim

@@ -1,4 +0,0 @@
-" Author: Sumner Evans <sumner.evans98@gmail.com>
-" Description: write-good for AsciiDoc files
-
-call ale#handlers#writegood#DefineLinter('asciidoc')

ale_linters/asm/gcc.vim

@@ -1,16 +1,12 @@
 " Author: Lucas Kolstad <lkolstad@uw.edu>
 " Description: gcc linter for asm files
 
-call ale#Set('asm_gcc_executable', 'gcc')
-call ale#Set('asm_gcc_options', '-Wall')
+let g:ale_asm_gcc_options = get(g:, 'ale_asm_gcc_options', '-Wall')
 
 function! ale_linters#asm#gcc#GetCommand(buffer) abort
-    " `-o /dev/null` or `-o null` is needed to catch all errors,
-    " -fsyntax-only doesn't catch everything.
-    return '%e -x assembler'
-    \   . ' -o ' . g:ale#util#nul_file
-    \   . '-iquote %s:h'
-    \   . ' ' . ale#Var(a:buffer, 'asm_gcc_options') . ' -'
+    return 'gcc -x assembler -fsyntax-only '
+    \    . '-iquote ' . ale#Escape(fnamemodify(bufname(a:buffer), ':p:h'))
+    \    . ' ' . ale#Var(a:buffer, 'asm_gcc_options') . ' -'
 endfunction
 
 function! ale_linters#asm#gcc#Handle(buffer, lines) abort
@@ -31,7 +27,7 @@ endfunction
 call ale#linter#Define('asm', {
 \    'name': 'gcc',
 \    'output_stream': 'stderr',
-\    'executable': {b -> ale#Var(b, 'asm_gcc_executable')},
-\    'command': function('ale_linters#asm#gcc#GetCommand'),
+\    'executable': 'gcc',
+\    'command_callback': 'ale_linters#asm#gcc#GetCommand',
 \    'callback': 'ale_linters#asm#gcc#Handle',
 \})

ale_linters/avra/avra.vim

@@ -1,36 +0,0 @@
-" Author: Utkarsh Verma <utkarshverma@protonmail.com>
-" Description: AVRA linter for avra syntax.
-
-call ale#Set('avra_avra_executable', 'avra')
-call ale#Set('avra_avra_options', '')
-
-function! ale_linters#avra#avra#GetCommand(buffer) abort
-    return '%e'
-    \   . ' %t'
-    \   . ale#Pad(ale#Var(a:buffer, 'avra_avra_options'))
-    \   . ' -o ' . g:ale#util#nul_file
-endfunction
-
-function! ale_linters#avra#avra#Handle(buffer, lines) abort
-    " Note that we treat 'fatal' as errors.
-    let l:pattern = '^\S\+(\(\d\+\))\s\+:\s\+\(\S\+\)\s\+:\s\+\(.\+\)$'
-    let l:output = []
-
-    for l:match in ale#util#GetMatches(a:lines, l:pattern)
-        call add(l:output, {
-        \ 'lnum': l:match[1] + 0,
-        \ 'type': l:match[2] =~? 'Error' ? 'E' : 'W',
-        \ 'text': l:match[3],
-        \})
-    endfor
-
-    return l:output
-endfunction
-
-call ale#linter#Define('avra', {
-\   'name': 'avra',
-\   'output_stream': 'stderr',
-\   'executable': {b -> ale#Var(b, 'avra_avra_executable')},
-\   'command': function('ale_linters#avra#avra#GetCommand'),
-\   'callback': 'ale_linters#avra#avra#Handle',
-\})

ale_linters/awk/gawk.vim

@@ -1,23 +1,26 @@
 " Author: kmarc <korondi.mark@gmail.com>
 " Description: This file adds support for using GNU awk with sripts.
 
-call ale#Set('awk_gawk_executable', 'gawk')
-call ale#Set('awk_gawk_options', '')
+let g:ale_awk_gawk_executable =
+\   get(g:, 'ale_awk_gawk_executable', 'gawk')
+
+let g:ale_awk_gawk_options =
+\   get(g:, 'ale_awk_gawk_options', '')
+
+function! ale_linters#awk#gawk#GetExecutable(buffer) abort
+    return ale#Var(a:buffer, 'awk_gawk_executable')
+endfunction
 
 function! ale_linters#awk#gawk#GetCommand(buffer) abort
-    " note the --source 'BEGIN ...' is to prevent
-    " gawk from attempting to execute the body of the script
-    " it is linting.
-    return '%e --source ' . ale#Escape('BEGIN { exit } END { exit 1 }')
-    \   . ' --lint'
-    \   .  ale#Pad(ale#Var(a:buffer, 'awk_gawk_options'))
-    \   . ' -f %t /dev/null'
+    return ale_linters#awk#gawk#GetExecutable(a:buffer)
+    \   . ' ' . ale#Var(a:buffer, 'awk_gawk_options')
+    \   . ' ' . '-f %t --lint /dev/null'
 endfunction
 
 call ale#linter#Define('awk', {
 \   'name': 'gawk',
-\   'executable': {b -> ale#Var(b, 'awk_gawk_executable')},
-\   'command': function('ale_linters#awk#gawk#GetCommand'),
-\   'callback': 'ale#handlers#gawk#HandleGawkFormat',
+\   'executable_callback': 'ale_linters#awk#gawk#GetExecutable',
+\   'command_callback': 'ale_linters#awk#gawk#GetCommand',
+\   'callback': 'ale#handlers#cpplint#HandleCppLintFormat',
 \   'output_stream': 'both'
 \})

ale_linters/bats/shellcheck.vim

@@ -1,4 +0,0 @@
-" Author: Ian2020 <https://github.com/Ian2020>
-" Description: shellcheck linter for bats scripts.
-
-call ale#handlers#shellcheck#DefineLinter('bats')

ale_linters/bib/bibclean.vim

@@ -1,80 +0,0 @@
-" Author: Horacio Sanson - https://github.com/hsanson
-" Description: Support for bibclean linter for BibTeX files.
-
-call ale#Set('bib_bibclean_executable', 'bibclean')
-
-function! ale_linters#bib#bibclean#GetCommand(buffer) abort
-    let l:executable = ale#Var(a:buffer, 'bib_bibclean_executable')
-
-    return ale#Escape(l:executable) . ' -file-position '
-endfunction
-
-function! ale_linters#bib#bibclean#get_type(str) abort
-    if a:str is# '??'
-        return 'E'
-    else
-        return 'W'
-    endif
-endfunction
-
-function! ale_linters#bib#bibclean#match_msg(line) abort
-    " Legacy message pattern works for bibclean <= v2.11.4. If empty, try
-    " the new message pattern for bibtex > v2.11.4
-    let l:matches_legacy = matchlist(a:line, '^\(.*\) "stdin", line \(\d\+\): \(.*\)$')
-
-    return ! empty(l:matches_legacy) ? l:matches_legacy
-    \ : matchlist(a:line, '^\(.*\) stdin:\(\d\+\):\(.*\)$')
-endfunction
-
-function! ale_linters#bib#bibclean#match_entry(line) abort
-    return matchlist(a:line, 'Entry   input byte=.* line=\(.*\) column=\(.*\) output .*$')
-endfunction
-
-function! ale_linters#bib#bibclean#match_value(line) abort
-    return matchlist(a:line, 'Value   input byte=.* line=\(.*\) column=\(.*\) output .*$')
-endfunction
-
-function! ale_linters#bib#bibclean#Handle(buffer, lines) abort
-    let l:output = []
-
-    let l:type = 'E'
-    let l:msg  = ''
-
-    for l:line in a:lines
-        if empty(l:msg)
-            let l:mlist = ale_linters#bib#bibclean#match_msg(l:line)
-
-            if !empty(l:mlist)
-                let l:msg = l:mlist[3]
-                let l:type = ale_linters#bib#bibclean#get_type(l:mlist[1])
-            endif
-        else
-            if l:type is# 'E'
-                let l:mlist = ale_linters#bib#bibclean#match_entry(l:line)
-            else
-                let l:mlist = ale_linters#bib#bibclean#match_value(l:line)
-            endif
-
-            if !empty(l:mlist)
-                call add(l:output, {
-                \ 'lnum': l:mlist[1],
-                \ 'col': l:mlist[2],
-                \ 'text': l:msg,
-                \ 'type': l:type
-                \})
-
-                let l:msg = ''
-            endif
-        endif
-    endfor
-
-    return l:output
-endfunction
-
-call ale#linter#Define('bib', {
-\   'name': 'bibclean',
-\   'executable': {b -> ale#Var(b, 'bib_bibclean_executable')},
-\   'command': function('ale_linters#bib#bibclean#GetCommand'),
-\   'output_stream': 'stderr',
-\   'callback': 'ale_linters#bib#bibclean#Handle',
-\})

ale_linters/bitbake/oelint_adv.vim

@@ -1,47 +0,0 @@
-" Author: offa
-" Description: oelint-adv for BitBake files
-
-call ale#Set('bitbake_oelint_adv_executable', 'oelint-adv')
-call ale#Set('bitbake_oelint_adv_options', '')
-call ale#Set('bitbake_oelint_adv_config', '.oelint.cfg')
-
-function! ale_linters#bitbake#oelint_adv#Command(buffer) abort
-    let l:config_file = ale#path#FindNearestFile(a:buffer,
-    \    ale#Var(a:buffer, 'bitbake_oelint_adv_config'))
-
-    return ((!empty(l:config_file))
-    \    ? 'OELINT_CONFIG=' . ale#Escape(l:config_file) . ' '
-    \    : '')
-    \    . '%e --quiet '
-    \    . ale#Pad(ale#Var(a:buffer, 'bitbake_oelint_adv_options')) .  '%s'
-endfunction
-
-function! ale_linters#bitbake#oelint_adv#Handle(buffer, lines) abort
-    let l:pattern = '\v^(.+):(.+):(.+):(.+):(.+)$'
-    let l:output = []
-
-    for l:match in ale#util#GetMatches(a:lines, l:pattern)
-        call add(l:output, {
-        \    'lnum': str2nr(l:match[2]),
-        \    'type': l:match[3] is# 'error'
-        \          ? 'E' : (l:match[3] is# 'warning' ? 'W' : 'I'),
-        \    'text': StripAnsiCodes(l:match[5]),
-        \    'code': l:match[4]
-        \    })
-    endfor
-
-    return l:output
-endfunction
-
-function! StripAnsiCodes(line) abort
-    return substitute(a:line, '\e\[[0-9;]\+[mK]', '', 'g')
-endfunction
-
-call ale#linter#Define('bitbake', {
-\    'name': 'oelint_adv',
-\    'output_stream': 'both',
-\    'executable': {b -> ale#Var(b, 'bitbake_oelint_adv_executable')},
-\    'cwd': '%s:h',
-\    'command': function('ale_linters#bitbake#oelint_adv#Command'),
-\    'callback': 'ale_linters#bitbake#oelint_adv#Handle',
-\    })

ale_linters/c/cc.vim

@@ -1,53 +0,0 @@
-" Author: w0rp <devw0rp@gmail.com>
-" Description: A C compiler linter for C files with gcc/clang, etc.
-
-call ale#Set('c_cc_executable', '<auto>')
-call ale#Set('c_cc_options', '-std=c11 -Wall')
-
-function! ale_linters#c#cc#GetExecutable(buffer) abort
-    let l:executable = ale#Var(a:buffer, 'c_cc_executable')
-
-    " Default to either clang or gcc.
-    if l:executable is# '<auto>'
-        if ale#engine#IsExecutable(a:buffer, 'clang')
-            let l:executable = 'clang'
-        else
-            let l:executable = 'gcc'
-        endif
-    endif
-
-    return l:executable
-endfunction
-
-function! ale_linters#c#cc#GetCommand(buffer, output) abort
-    let l:cflags = ale#c#GetCFlags(a:buffer, a:output)
-    let l:ale_flags = ale#Var(a:buffer, 'c_cc_options')
-
-    if l:cflags =~# '-std='
-        let l:ale_flags = substitute(
-        \   l:ale_flags,
-        \   '-std=\(c\|gnu\)[0-9]\{2\}',
-        \   '',
-        \   'g')
-    endif
-
-    " -iquote with the directory the file is in makes #include work for
-    "  headers in the same directory.
-    "
-    " `-o /dev/null` or `-o null` is needed to catch all errors,
-    " -fsyntax-only doesn't catch everything.
-    return '%e -S -x c'
-    \   . ' -o ' . g:ale#util#nul_file
-    \   . ' -iquote %s:h'
-    \   . ale#Pad(l:cflags)
-    \   . ale#Pad(l:ale_flags) . ' -'
-endfunction
-
-call ale#linter#Define('c', {
-\   'name': 'cc',
-\   'aliases': ['gcc', 'clang'],
-\   'output_stream': 'stderr',
-\   'executable': function('ale_linters#c#cc#GetExecutable'),
-\   'command': {b -> ale#c#RunMakeCommand(b, function('ale_linters#c#cc#GetCommand'))},
-\   'callback': 'ale#handlers#gcc#HandleGCCFormatWithIncludes',
-\})

ale_linters/c/ccls.vim

@@ -1,15 +0,0 @@
-" Author: Ye Jingchen <ye.jingchen@gmail.com>, Ben Falconer <ben@falconers.me.uk>, jtalowell <jtalowell@protonmail.com>
-" Description: A language server for C
-
-call ale#Set('c_ccls_executable', 'ccls')
-call ale#Set('c_ccls_init_options', {})
-call ale#Set('c_build_dir', '')
-
-call ale#linter#Define('c', {
-\   'name': 'ccls',
-\   'lsp': 'stdio',
-\   'executable': {b -> ale#Var(b, 'c_ccls_executable')},
-\   'command': '%e',
-\   'project_root': function('ale#handlers#ccls#GetProjectRoot'),
-\   'initialization_options': {b -> ale#handlers#ccls#GetInitOpts(b, 'c_ccls_init_options')},
-\})

ale_linters/c/clang.vim

@@ -0,0 +1,29 @@
+" Author: Masahiro H https://github.com/mshr-h
+" Description: clang linter for c files
+
+call ale#Set('c_clang_executable', 'clang')
+call ale#Set('c_clang_options', '-std=c11 -Wall')
+
+function! ale_linters#c#clang#GetExecutable(buffer) abort
+    return ale#Var(a:buffer, 'c_clang_executable')
+endfunction
+
+function! ale_linters#c#clang#GetCommand(buffer) abort
+    let l:paths = ale#c#FindLocalHeaderPaths(a:buffer)
+
+    " -iquote with the directory the file is in makes #include work for
+    "  headers in the same directory.
+    return ale#Escape(ale_linters#c#clang#GetExecutable(a:buffer))
+    \   . ' -S -x c -fsyntax-only '
+    \   . '-iquote ' . ale#Escape(fnamemodify(bufname(a:buffer), ':p:h')) . ' '
+    \   . ale#c#IncludeOptions(l:paths)
+    \   . ale#Var(a:buffer, 'c_clang_options') . ' -'
+endfunction
+
+call ale#linter#Define('c', {
+\   'name': 'clang',
+\   'output_stream': 'stderr',
+\   'executable_callback': 'ale_linters#c#clang#GetExecutable',
+\   'command_callback': 'ale_linters#c#clang#GetCommand',
+\   'callback': 'ale#handlers#gcc#HandleGCCFormat',
+\})

ale_linters/c/clangd.vim

@@ -1,22 +0,0 @@
-" Author: Andrey Melentyev <andrey.melentyev@protonmail.com>
-" Description: Clangd language server
-
-call ale#Set('c_clangd_executable', 'clangd')
-call ale#Set('c_clangd_options', '')
-call ale#Set('c_build_dir', '')
-
-function! ale_linters#c#clangd#GetCommand(buffer) abort
-    let l:build_dir = ale#c#GetBuildDirectory(a:buffer)
-
-    return '%e'
-    \    . ale#Pad(ale#Var(a:buffer, 'c_clangd_options'))
-    \    . (!empty(l:build_dir) ? ' -compile-commands-dir=' . ale#Escape(l:build_dir) : '')
-endfunction
-
-call ale#linter#Define('c', {
-\   'name': 'clangd',
-\   'lsp': 'stdio',
-\   'executable': {b -> ale#Var(b, 'c_clangd_executable')},
-\   'command': function('ale_linters#c#clangd#GetCommand'),
-\   'project_root': function('ale#c#FindProjectRoot'),
-\})

ale_linters/c/clangtidy.vim

@@ -10,33 +10,45 @@ call ale#Set('c_clangtidy_executable', 'clang-tidy')
 " Consult the check list in clang-tidy's documentation:
 " http://clang.llvm.org/extra/clang-tidy/checks/list.html
 
-call ale#Set('c_clangtidy_checks', [])
-" Set this option to manually set some options for clang-tidy to use as compile
-" flags.
+call ale#Set('c_clangtidy_checks', ['*'])
+" Set this option to manually set some options for clang-tidy.
 " This will disable compile_commands.json detection.
 call ale#Set('c_clangtidy_options', '')
-" Set this option to manually set options for clang-tidy directly.
-call ale#Set('c_clangtidy_extra_options', '')
 call ale#Set('c_build_dir', '')
 
-function! ale_linters#c#clangtidy#GetCommand(buffer, output) abort
-    let l:checks = join(ale#Var(a:buffer, 'c_clangtidy_checks'), ',')
-    let l:build_dir = ale#c#GetBuildDirectory(a:buffer)
-    let l:options = ''
+function! ale_linters#c#clangtidy#GetExecutable(buffer) abort
+    return ale#Var(a:buffer, 'c_clangtidy_executable')
+endfunction
 
-    " Get the extra options if we couldn't find a build directory.
-    if empty(l:build_dir)
-        let l:options = ale#Var(a:buffer, 'c_clangtidy_options')
-        let l:cflags = ale#c#GetCFlags(a:buffer, a:output)
-        let l:options .= !empty(l:options) ? ale#Pad(l:cflags) : l:cflags
+function! s:GetBuildDirectory(buffer) abort
+    " Don't include build directory for header files, as compile_commands.json
+    " files don't consider headers to be translation units, and provide no
+    " commands for compiling header files.
+    if expand('#' . a:buffer) =~# '\v\.(h|hpp)$'
+        return ''
     endif
 
-    " Get the options to pass directly to clang-tidy
-    let l:extra_options = ale#Var(a:buffer, 'c_clangtidy_extra_options')
+    let l:build_dir = ale#Var(a:buffer, 'c_build_dir')
 
-    return '%e'
+    " c_build_dir has the priority if defined
+    if !empty(l:build_dir)
+        return l:build_dir
+    endif
+
+    return ale#c#FindCompileCommands(a:buffer)
+endfunction
+
+function! ale_linters#c#clangtidy#GetCommand(buffer) abort
+    let l:checks = join(ale#Var(a:buffer, 'c_clangtidy_checks'), ',')
+    let l:build_dir = s:GetBuildDirectory(a:buffer)
+
+    " Get the extra options if we couldn't find a build directory.
+    let l:options = empty(l:build_dir)
+    \   ? ale#Var(a:buffer, 'c_clangtidy_options')
+    \   : ''
+
+    return ale#Escape(ale_linters#c#clangtidy#GetExecutable(a:buffer))
     \   . (!empty(l:checks) ? ' -checks=' . ale#Escape(l:checks) : '')
-    \   . (!empty(l:extra_options) ? ' ' . ale#Escape(l:extra_options) : '')
     \   . ' %s'
     \   . (!empty(l:build_dir) ? ' -p ' . ale#Escape(l:build_dir) : '')
     \   . (!empty(l:options) ? ' -- ' . l:options : '')
@@ -45,8 +57,8 @@ endfunction
 call ale#linter#Define('c', {
 \   'name': 'clangtidy',
 \   'output_stream': 'stdout',
-\   'executable': {b -> ale#Var(b, 'c_clangtidy_executable')},
-\   'command': {b -> ale#c#RunMakeCommand(b, function('ale_linters#c#clangtidy#GetCommand'))},
+\   'executable_callback': 'ale_linters#c#clangtidy#GetExecutable',
+\   'command_callback': 'ale_linters#c#clangtidy#GetCommand',
 \   'callback': 'ale#handlers#gcc#HandleGCCFormat',
 \   'lint_file': 1,
 \})

ale_linters/c/cppcheck.vim

@@ -4,26 +4,36 @@
 call ale#Set('c_cppcheck_executable', 'cppcheck')
 call ale#Set('c_cppcheck_options', '--enable=style')
 
-function! ale_linters#c#cppcheck#GetCommand(buffer) abort
-    let l:compile_commands_option = ale#handlers#cppcheck#GetCompileCommandsOptions(a:buffer)
-    let l:buffer_path_include = empty(l:compile_commands_option)
-    \   ? ale#handlers#cppcheck#GetBufferPathIncludeOptions(a:buffer)
-    \   : ''
-    let l:template = ' --template=' . ale#Escape('{file}:{line}:{column}: {severity}:{inconclusive:inconclusive:} {message} [{id}]\\n{code}')
+function! ale_linters#c#cppcheck#GetExecutable(buffer) abort
+    return ale#Var(a:buffer, 'c_cppcheck_executable')
+endfunction
 
-    return '%e -q --language=c'
-    \   . l:template
-    \   . ale#Pad(l:compile_commands_option)
-    \   . ale#Pad(ale#Var(a:buffer, 'c_cppcheck_options'))
-    \   . l:buffer_path_include
+function! ale_linters#c#cppcheck#GetCommand(buffer) abort
+    " Search upwards from the file for compile_commands.json.
+    "
+    " If we find it, we'll `cd` to where the compile_commands.json file is,
+    " then use the file to set up import paths, etc.
+    let l:compile_commmands_path = ale#path#FindNearestFile(a:buffer, 'compile_commands.json')
+
+    let l:cd_command = !empty(l:compile_commmands_path)
+    \   ? ale#path#CdString(fnamemodify(l:compile_commmands_path, ':h'))
+    \   : ''
+    let l:compile_commands_option = !empty(l:compile_commmands_path)
+    \   ? '--project=compile_commands.json '
+    \   : ''
+
+    return l:cd_command
+    \   . ale#Escape(ale_linters#c#cppcheck#GetExecutable(a:buffer))
+    \   . ' -q --language=c '
+    \   . l:compile_commands_option
+    \   . ale#Var(a:buffer, 'c_cppcheck_options')
     \   . ' %t'
 endfunction
 
 call ale#linter#Define('c', {
 \   'name': 'cppcheck',
 \   'output_stream': 'both',
-\   'executable': {b -> ale#Var(b, 'c_cppcheck_executable')},
-\   'cwd': function('ale#handlers#cppcheck#GetCwd'),
-\   'command': function('ale_linters#c#cppcheck#GetCommand'),
+\   'executable_callback': 'ale_linters#c#cppcheck#GetExecutable',
+\   'command_callback': 'ale_linters#c#cppcheck#GetCommand',
 \   'callback': 'ale#handlers#cppcheck#HandleCppCheckFormat',
 \})

ale_linters/c/cpplint.vim

@@ -1,20 +0,0 @@
-" Author: Justin Huang <justin.y.huang@live.com>
-" Description: cpplint for c files
-
-call ale#Set('c_cpplint_executable', 'cpplint')
-call ale#Set('c_cpplint_options', '')
-
-function! ale_linters#c#cpplint#GetCommand(buffer) abort
-    let l:options = ale#Var(a:buffer, 'c_cpplint_options')
-
-    return '%e' . ale#Pad(l:options) . ' %s'
-endfunction
-
-call ale#linter#Define('c', {
-\   'name': 'cpplint',
-\   'output_stream': 'stderr',
-\   'executable': {b -> ale#Var(b, 'c_cpplint_executable')},
-\   'command': function('ale_linters#c#cpplint#GetCommand'),
-\   'callback': 'ale#handlers#cpplint#HandleCppLintFormat',
-\   'lint_file': 1,
-\})

ale_linters/c/cquery.vim

@@ -1,30 +0,0 @@
-" Author: Ben Falconer <ben@falconers.me.uk>, jtalowell <jtalowell@protonmail.com>
-" Description: A language server for C
-
-call ale#Set('c_cquery_executable', 'cquery')
-call ale#Set('c_cquery_cache_directory', expand('~/.cache/cquery'))
-
-function! ale_linters#c#cquery#GetProjectRoot(buffer) abort
-    " Try to find cquery configuration files first.
-    let l:config = ale#path#FindNearestFile(a:buffer, '.cquery')
-
-    if !empty(l:config)
-        return fnamemodify(l:config, ':h')
-    endif
-
-    " Fall back on default project root detection.
-    return ale#c#FindProjectRoot(a:buffer)
-endfunction
-
-function! ale_linters#c#cquery#GetInitializationOptions(buffer) abort
-    return {'cacheDirectory': ale#Var(a:buffer, 'c_cquery_cache_directory')}
-endfunction
-
-call ale#linter#Define('c', {
-\   'name': 'cquery',
-\   'lsp': 'stdio',
-\   'executable': {b -> ale#Var(b, 'c_cquery_executable')},
-\   'command': '%e',
-\   'project_root': function('ale_linters#c#cquery#GetProjectRoot'),
-\   'initialization_options': function('ale_linters#c#cquery#GetInitializationOptions'),
-\})

ale_linters/c/cspell.vim

@@ -1,5 +0,0 @@
-scriptencoding utf-8
-" Author: David Houston <houstdav000>
-" Description: cspell support for C files.
-
-call ale#handlers#cspell#DefineLinter('c')

ale_linters/c/flawfinder.vim

@@ -1,25 +0,0 @@
-" Author: Christian Gibbons <cgibbons@gmu.edu>
-" Description: flawfinder linter for c files
-
-call ale#Set('c_flawfinder_executable', 'flawfinder')
-call ale#Set('c_flawfinder_options', '')
-call ale#Set('c_flawfinder_minlevel', 1)
-call ale#Set('c_flawfinder_error_severity', 6)
-
-function! ale_linters#c#flawfinder#GetCommand(buffer) abort
-    " Set the minimum vulnerability level for flawfinder to bother with
-    let l:minlevel = ' --minlevel=' . ale#Var(a:buffer, 'c_flawfinder_minlevel')
-
-    return '%e -CDQS'
-    \  . ale#Pad(ale#Var(a:buffer, 'c_flawfinder_options'))
-    \  . l:minlevel
-    \  . ' %t'
-endfunction
-
-call ale#linter#Define('c', {
-\  'name': 'flawfinder',
-\  'output_stream': 'stdout',
-\  'executable': {b -> ale#Var(b, 'c_flawfinder_executable')},
-\  'command': function('ale_linters#c#flawfinder#GetCommand'),
-\  'callback': 'ale#handlers#flawfinder#HandleFlawfinderFormat',
-\})

ale_linters/c/gcc.vim

@@ -0,0 +1,29 @@
+" Author: w0rp <devw0rp@gmail.com>
+" Description: gcc linter for c files
+
+call ale#Set('c_gcc_executable', 'gcc')
+call ale#Set('c_gcc_options', '-std=c11 -Wall')
+
+function! ale_linters#c#gcc#GetExecutable(buffer) abort
+    return ale#Var(a:buffer, 'c_gcc_executable')
+endfunction
+
+function! ale_linters#c#gcc#GetCommand(buffer) abort
+    let l:paths = ale#c#FindLocalHeaderPaths(a:buffer)
+
+    " -iquote with the directory the file is in makes #include work for
+    "  headers in the same directory.
+    return ale#Escape(ale_linters#c#gcc#GetExecutable(a:buffer))
+    \   . ' -S -x c -fsyntax-only '
+    \   . '-iquote ' . ale#Escape(fnamemodify(bufname(a:buffer), ':p:h')) . ' '
+    \   . ale#c#IncludeOptions(l:paths)
+    \   . ale#Var(a:buffer, 'c_gcc_options') . ' -'
+endfunction
+
+call ale#linter#Define('c', {
+\   'name': 'gcc',
+\   'output_stream': 'stderr',
+\   'executable_callback': 'ale_linters#c#gcc#GetExecutable',
+\   'command_callback': 'ale_linters#c#gcc#GetCommand',
+\   'callback': 'ale#handlers#gcc#HandleGCCFormat',
+\})

ale_linters/cairo/starknet.vim

@@ -1,37 +0,0 @@
-" Author: 0xHyoga <0xHyoga@gmx.com>
-" Description: Report starknet-compile errors in cairo code
-
-call ale#Set('cairo_starknet_executable', 'starknet-compile')
-call ale#Set('cairo_starknet_options', '')
-
-function! ale_linters#cairo#starknet#Handle(buffer, lines) abort
-    " Error always on the first line
-    " e.g ex01.cairo:20:6: Could not find module 'contracts.utils.ex00_base'. Searched in the following paths:
-    let l:pattern = '\v\.cairo:(\d+):(\d+):+ (.*)'
-    let l:output = []
-
-    for l:match in ale#util#GetMatches(a:lines, l:pattern)
-        call add(l:output, {
-        \   'lnum': str2nr(l:match[1]),
-        \   'col': str2nr(l:match[2]),
-        \   'type': 'E',
-        \   'text': l:match[3],
-        \})
-    endfor
-
-    return l:output
-endfunction
-
-function! ale_linters#cairo#starknet#GetCommand(buffer) abort
-    let l:executable = ale#Var(a:buffer, 'cairo_starknet_executable')
-
-    return l:executable . ale#Pad(ale#Var(a:buffer, 'cairo_starknet_options')) . ' %s'
-endfunction
-
-call ale#linter#Define('cairo', {
-\   'name': 'starknet',
-\   'executable': {b -> ale#Var(b, 'cairo_starknet_executable')},
-\   'command': function('ale_linters#cairo#starknet#GetCommand'),
-\   'callback': 'ale_linters#cairo#starknet#Handle',
-\   'output_stream': 'stderr',
-\})

ale_linters/chef/cookstyle.vim

@@ -1,54 +0,0 @@
-" Author: Raphael Hoegger - https://github.com/pfuender
-" Description: Cookstyle (RuboCop based), a code style analyzer for Ruby files
-
-call ale#Set('chef_cookstyle_executable', 'cookstyle')
-call ale#Set('chef_cookstyle_options', '')
-
-function! ale_linters#chef#cookstyle#GetCommand(buffer) abort
-    let l:options = ale#Var(a:buffer, 'chef_cookstyle_options')
-
-    return '%e' . ale#Pad(escape(l:options, '~')) . ' --force-exclusion --format json --stdin ' . ' %s'
-endfunction
-
-function! ale_linters#chef#cookstyle#Handle(buffer, lines) abort
-    if len(a:lines) == 0
-        return []
-    endif
-
-    let l:errors = ale#util#FuzzyJSONDecode(a:lines[0], {})
-
-    if !has_key(l:errors, 'summary')
-    \|| l:errors['summary']['offense_count'] == 0
-    \|| empty(l:errors['files'])
-        return []
-    endif
-
-    let l:output = []
-
-    for l:error in l:errors['files'][0]['offenses']
-        let l:start_col = str2nr(l:error['location']['start_column'])
-        let l:end_col = str2nr(l:error['location']['last_column'])
-
-        if !l:end_col
-            let l:end_col = l:start_col + 1
-        endif
-
-        call add(l:output, {
-        \   'lnum': str2nr(l:error['location']['line']),
-        \   'col': l:start_col,
-        \   'end_col': l:end_col,
-        \   'code': l:error['cop_name'],
-        \   'text': l:error['message'],
-        \   'type': l:error['severity'] is? 'convention' ? 'W' : 'E',
-        \})
-    endfor
-
-    return l:output
-endfunction
-
-call ale#linter#Define('chef', {
-\   'name': 'cookstyle',
-\   'executable': {b -> ale#Var(b, 'chef_cookstyle_executable')},
-\   'command': function('ale_linters#chef#cookstyle#GetCommand'),
-\   'callback': 'ale_linters#chef#cookstyle#Handle',
-\})

ale_linters/chef/foodcritic.vim

@@ -1,30 +1,24 @@
 " Author: Edward Larkey <edwlarkey@mac.com>
 " Author: Jose Junior <jose.junior@gmail.com>
-" Author: w0rp <devw0rp@gmail.com>
 " Description: This file adds the foodcritic linter for Chef files.
 
-call ale#Set('chef_foodcritic_executable', 'foodcritic')
-call ale#Set('chef_foodcritic_options', '')
-
-function! ale_linters#chef#foodcritic#GetCommand(buffer) abort
-    let l:options = ale#Var(a:buffer, 'chef_foodcritic_options')
-
-    return '%e' . ale#Pad(escape(l:options, '~')) . ' %s'
-endfunction
+" Support options!
+let g:ale_chef_foodcritic_options = get(g:, 'ale_chef_foodcritic_options', '')
+let g:ale_chef_foodcritic_executable = get(g:, 'ale_chef_foodcritic_executable', 'foodcritic')
 
 function! ale_linters#chef#foodcritic#Handle(buffer, lines) abort
     " Matches patterns line the following:
     "
     " FC002: Avoid string interpolation where not required: httpd.rb:13
-    let l:pattern = '\v([^:]+): (.+): ([a-zA-Z]?:?[^:]+):(\d+)$'
+    let l:pattern = '^\(.\+:\s.\+\):\s\(.\+\):\(\d\+\)$'
     let l:output = []
 
     for l:match in ale#util#GetMatches(a:lines, l:pattern)
+        let l:text = l:match[1]
+
         call add(l:output, {
-        \   'code': l:match[1],
-        \   'text': l:match[2],
-        \   'filename': l:match[3],
-        \   'lnum': l:match[4] + 0,
+        \   'lnum': l:match[3] + 0,
+        \   'text': l:text,
         \   'type': 'W',
         \})
     endfor
@@ -32,10 +26,17 @@ function! ale_linters#chef#foodcritic#Handle(buffer, lines) abort
     return l:output
 endfunction
 
+function! ale_linters#chef#foodcritic#GetCommand(buffer) abort
+    return printf('%s %s %%t',
+    \   ale#Var(a:buffer, 'chef_foodcritic_executable'),
+    \   escape(ale#Var(a:buffer, 'chef_foodcritic_options'), '~')
+    \)
+endfunction
+
+
 call ale#linter#Define('chef', {
 \   'name': 'foodcritic',
-\   'executable': {b -> ale#Var(b, 'chef_foodcritic_executable')},
-\   'command': function('ale_linters#chef#foodcritic#GetCommand'),
+\   'executable': 'foodcritic',
+\   'command_callback': 'ale_linters#chef#foodcritic#GetCommand',
 \   'callback': 'ale_linters#chef#foodcritic#Handle',
-\   'lint_file': 1,
 \})

ale_linters/clojure/clj_kondo.vim

@@ -1,46 +0,0 @@
-" Author: Masashi Iizuka <liquidz.uo@gmail.com>
-" Description: linter for clojure using clj-kondo https://github.com/borkdude/clj-kondo
-
-call ale#Set('clojure_clj_kondo_options', '--cache')
-
-function! ale_linters#clojure#clj_kondo#GetCommand(buffer) abort
-    let l:options = ale#Var(a:buffer, 'clojure_clj_kondo_options')
-
-    let l:command = 'clj-kondo'
-    \   . ale#Pad(l:options)
-    \   . ' --lint %t'
-
-    return l:command
-endfunction
-
-function! ale_linters#clojure#clj_kondo#HandleCljKondoFormat(buffer, lines) abort
-    " output format
-    " <filename>:<line>:<column>: <issue type>: <message>
-    let l:pattern = '\v^[a-zA-Z]?:?[^:]+:(\d+)?:(\d+)?:? ((Exception|error|warning): ?(.+))$'
-    let l:output = []
-
-    for l:match in ale#util#GetMatches(a:lines, l:pattern)
-        let l:type = 'E'
-
-        if l:match[4] is? 'warning'
-            let l:type = 'W'
-        endif
-
-        call add(l:output, {
-        \   'lnum': l:match[1] + 0,
-        \   'col': l:match[2] + 0,
-        \   'text': l:match[3],
-        \   'type': l:type,
-        \})
-    endfor
-
-    return l:output
-endfunction
-
-call ale#linter#Define('clojure', {
-\   'name': 'clj-kondo',
-\   'output_stream': 'stdout',
-\   'executable': 'clj-kondo',
-\   'command': function('ale_linters#clojure#clj_kondo#GetCommand'),
-\   'callback': 'ale_linters#clojure#clj_kondo#HandleCljKondoFormat',
-\})

ale_linters/clojure/joker.vim

@@ -1,34 +0,0 @@
-" Author: Nic West <nicwest@mailbox.org>
-" Description: linter for clojure using joker https://github.com/candid82/joker
-
-function! ale_linters#clojure#joker#HandleJokerFormat(buffer, lines) abort
-    " output format
-    " <filename>:<line>:<column>: <issue type>: <message>
-    let l:pattern = '\v^[a-zA-Z]?:?[^:]+:(\d+):(\d+):? ((Read error|Parse error|Parse warning|Exception): ?(.+))$'
-    let l:output = []
-
-    for l:match in ale#util#GetMatches(a:lines, l:pattern)
-        let l:type = 'E'
-
-        if l:match[4] is? 'Parse warning'
-            let l:type = 'W'
-        endif
-
-        call add(l:output, {
-        \   'lnum': l:match[1] + 0,
-        \   'col': l:match[2] + 0,
-        \   'text': l:match[3],
-        \   'type': l:type,
-        \})
-    endfor
-
-    return l:output
-endfunction
-
-call ale#linter#Define('clojure', {
-\   'name': 'joker',
-\   'output_stream': 'stderr',
-\   'executable': 'joker',
-\   'command': 'joker --working-dir %s --lint %t',
-\   'callback': 'ale_linters#clojure#joker#HandleJokerFormat',
-\})

ale_linters/cloudformation/cfn_python_lint.vim

@@ -1,36 +0,0 @@
-" Author: Yasuhiro Kiyota <yasuhiroki.duck@gmail.com>
-" Description: Support cfn-python-lint for AWS Cloudformation template file
-
-function! ale_linters#cloudformation#cfn_python_lint#Handle(buffer, lines) abort
-    " Matches patterns line the following:
-    "
-    " sample.template.yaml:96:7:96:15:E3012:Property Resources/Sample/Properties/FromPort should be of type Integer
-    let l:pattern = '\v^(.*):(\d+):(\d+):(\d+):(\d+):([[:alnum:]]+):(.*)$'
-    let l:output = []
-
-    for l:match in ale#util#GetMatches(a:lines, l:pattern)
-        let l:code = l:match[6]
-
-        if ale#path#IsBufferPath(a:buffer, l:match[1])
-            call add(l:output, {
-            \   'lnum': l:match[2],
-            \   'col': l:match[3],
-            \   'end_lnum': l:match[4],
-            \   'end_col': l:match[5],
-            \   'code': l:code,
-            \   'type': l:code[:0] is# 'E' ? 'E' : 'W',
-            \   'text': l:match[7]
-            \})
-        endif
-    endfor
-
-    return l:output
-endfunction
-
-call ale#linter#Define('cloudformation', {
-\   'name': 'cloudformation',
-\   'aliases': ['cfn-lint'],
-\   'executable': 'cfn-lint',
-\   'command': 'cfn-lint --template %t --format parseable',
-\   'callback': 'ale_linters#cloudformation#cfn_python_lint#Handle',
-\})

ale_linters/cmake/cmake_lint.vim

@@ -1,43 +0,0 @@
-" Author: Carl Smedstad <carl.smedstad at protonmail dot com>
-" Description: cmake-lint for cmake files
-
-let g:ale_cmake_cmake_lint_executable =
-\   get(g:, 'ale_cmake_cmake_lint_executable', 'cmake-lint')
-
-let g:ale_cmake_cmake_lint_options =
-\   get(g:, 'ale_cmake_cmake_lint_options', '')
-
-function! ale_linters#cmake#cmake_lint#Executable(buffer) abort
-    return ale#Var(a:buffer, 'cmake_cmake_lint_executable')
-endfunction
-
-function! ale_linters#cmake#cmake_lint#Command(buffer) abort
-    let l:executable = ale_linters#cmake#cmake_lint#Executable(a:buffer)
-    let l:options = ale#Var(a:buffer, 'cmake_cmake_lint_options')
-
-    return ale#Escape(l:executable) . ' ' . l:options . ' %t'
-endfunction
-
-function! ale_linters#cmake#cmake_lint#Handle(buffer, lines) abort
-    let l:pattern = '\v^[^:]+:(\d+),?(\d+)?:\s\[([A-Z]\d+)\]\s(.+)$'
-    let l:output = []
-
-    for l:match in ale#util#GetMatches(a:lines, l:pattern)
-        call add(l:output, {
-        \   'lnum': l:match[1] + 0,
-        \   'col': l:match[2] + 0,
-        \   'type': 'W',
-        \   'code': l:match[3],
-        \   'text': l:match[4],
-        \})
-    endfor
-
-    return l:output
-endfunction
-
-call ale#linter#Define('cmake', {
-\   'name': 'cmake_lint',
-\   'executable': function('ale_linters#cmake#cmake_lint#Executable'),
-\   'command': function('ale_linters#cmake#cmake_lint#Command'),
-\   'callback': 'ale_linters#cmake#cmake_lint#Handle',
-\})

ale_linters/cmake/cmakelint.vim

@@ -18,7 +18,7 @@ endfunction
 
 call ale#linter#Define('cmake', {
 \   'name': 'cmakelint',
-\   'executable': function('ale_linters#cmake#cmakelint#Executable'),
-\   'command': function('ale_linters#cmake#cmakelint#Command'),
+\   'executable_callback': 'ale_linters#cmake#cmakelint#Executable',
+\   'command_callback': 'ale_linters#cmake#cmakelint#Command',
 \   'callback': 'ale#handlers#unix#HandleAsWarning',
 \})

ale_linters/coffee/coffee.vim

@@ -16,8 +16,8 @@ endfunction
 
 call ale#linter#Define('coffee', {
 \   'name': 'coffee',
-\   'executable': function('ale_linters#coffee#coffee#GetExecutable'),
-\   'command': function('ale_linters#coffee#coffee#GetCommand'),
+\   'executable_callback': 'ale_linters#coffee#coffee#GetExecutable',
+\   'command_callback': 'ale_linters#coffee#coffee#GetCommand',
 \   'output_stream': 'stderr',
 \   'callback': 'ale#handlers#gcc#HandleGCCFormat',
 \})

ale_linters/coffee/coffeelint.vim

@@ -37,7 +37,7 @@ endfunction
 
 call ale#linter#Define('coffee', {
 \   'name': 'coffeelint',
-\   'executable': function('ale_linters#coffee#coffeelint#GetExecutable'),
-\   'command': function('ale_linters#coffee#coffeelint#GetCommand'),
+\   'executable_callback': 'ale_linters#coffee#coffeelint#GetExecutable',
+\   'command_callback': 'ale_linters#coffee#coffeelint#GetCommand',
 \   'callback': 'ale_linters#coffee#coffeelint#Handle',
 \})

ale_linters/cpp/cc.vim

@@ -1,53 +0,0 @@
-" Author: w0rp <devw0rp@gmail.com>
-" Description: A C++ compiler linter for C++ files with gcc/clang, etc.
-
-call ale#Set('cpp_cc_executable', '<auto>')
-call ale#Set('cpp_cc_options', '-std=c++14 -Wall')
-
-function! ale_linters#cpp#cc#GetExecutable(buffer) abort
-    let l:executable = ale#Var(a:buffer, 'cpp_cc_executable')
-
-    " Default to either clang++ or gcc.
-    if l:executable is# '<auto>'
-        if ale#engine#IsExecutable(a:buffer, 'clang++')
-            let l:executable = 'clang++'
-        else
-            let l:executable = 'gcc'
-        endif
-    endif
-
-    return l:executable
-endfunction
-
-function! ale_linters#cpp#cc#GetCommand(buffer, output) abort
-    let l:cflags = ale#c#GetCFlags(a:buffer, a:output)
-    let l:ale_flags = ale#Var(a:buffer, 'cpp_cc_options')
-
-    if l:cflags =~# '-std='
-        let l:ale_flags = substitute(
-        \   l:ale_flags,
-        \   '-std=\(c\|gnu\)++[0-9]\{2\}',
-        \   '',
-        \   'g')
-    endif
-
-    " -iquote with the directory the file is in makes #include work for
-    "  headers in the same directory.
-    "
-    " `-o /dev/null` or `-o null` is needed to catch all errors,
-    " -fsyntax-only doesn't catch everything.
-    return '%e -S -x c++'
-    \   . ' -o ' . g:ale#util#nul_file
-    \   . ' -iquote %s:h'
-    \   . ale#Pad(l:cflags)
-    \   . ale#Pad(l:ale_flags) . ' -'
-endfunction
-
-call ale#linter#Define('cpp', {
-\   'name': 'cc',
-\   'aliases': ['gcc', 'clang', 'g++', 'clang++'],
-\   'output_stream': 'stderr',
-\   'executable': function('ale_linters#cpp#cc#GetExecutable'),
-\   'command': {b -> ale#c#RunMakeCommand(b, function('ale_linters#cpp#cc#GetCommand'))},
-\   'callback': 'ale#handlers#gcc#HandleGCCFormatWithIncludes',
-\})

ale_linters/cpp/ccls.vim

@@ -1,15 +0,0 @@
-" Author: Ye Jingchen <ye.jingchen@gmail.com>, Ben Falconer <ben@falconers.me.uk>, jtalowell <jtalowell@protonmail.com>
-" Description: A language server for C++
-
-call ale#Set('cpp_ccls_executable', 'ccls')
-call ale#Set('cpp_ccls_init_options', {})
-call ale#Set('c_build_dir', '')
-
-call ale#linter#Define('cpp', {
-\   'name': 'ccls',
-\   'lsp': 'stdio',
-\   'executable': {b -> ale#Var(b, 'cpp_ccls_executable')},
-\   'command': '%e',
-\   'project_root': function('ale#handlers#ccls#GetProjectRoot'),
-\   'initialization_options': {b -> ale#handlers#ccls#GetInitOpts(b, 'cpp_ccls_init_options')},
-\})

ale_linters/cpp/clang.vim

@@ -0,0 +1,29 @@
+" Author: Tomota Nakamura <https://github.com/tomotanakamura>
+" Description: clang linter for cpp files
+
+call ale#Set('cpp_clang_executable', 'clang++')
+call ale#Set('cpp_clang_options', '-std=c++14 -Wall')
+
+function! ale_linters#cpp#clang#GetExecutable(buffer) abort
+    return ale#Var(a:buffer, 'cpp_clang_executable')
+endfunction
+
+function! ale_linters#cpp#clang#GetCommand(buffer) abort
+    let l:paths = ale#c#FindLocalHeaderPaths(a:buffer)
+
+    " -iquote with the directory the file is in makes #include work for
+    "  headers in the same directory.
+    return ale#Escape(ale_linters#cpp#clang#GetExecutable(a:buffer))
+    \   . ' -S -x c++ -fsyntax-only '
+    \   . '-iquote ' . ale#Escape(fnamemodify(bufname(a:buffer), ':p:h')) . ' '
+    \   . ale#c#IncludeOptions(l:paths)
+    \   . ale#Var(a:buffer, 'cpp_clang_options') . ' -'
+endfunction
+
+call ale#linter#Define('cpp', {
+\   'name': 'clang',
+\   'output_stream': 'stderr',
+\   'executable_callback': 'ale_linters#cpp#clang#GetExecutable',
+\   'command_callback': 'ale_linters#cpp#clang#GetCommand',
+\   'callback': 'ale#handlers#gcc#HandleGCCFormat',
+\})

ale_linters/cpp/clangcheck.vim

@@ -5,6 +5,10 @@ call ale#Set('cpp_clangcheck_executable', 'clang-check')
 call ale#Set('cpp_clangcheck_options', '')
 call ale#Set('c_build_dir', '')
 
+function! ale_linters#cpp#clangcheck#GetExecutable(buffer) abort
+    return ale#Var(a:buffer, 'cpp_clangcheck_executable')
+endfunction
+
 function! ale_linters#cpp#clangcheck#GetCommand(buffer) abort
     let l:user_options = ale#Var(a:buffer, 'cpp_clangcheck_options')
 
@@ -12,24 +16,24 @@ function! ale_linters#cpp#clangcheck#GetCommand(buffer) abort
     let l:build_dir = ale#Var(a:buffer, 'c_build_dir')
 
     if empty(l:build_dir)
-        let [l:root, l:json_file] = ale#c#FindCompileCommands(a:buffer)
-        let l:build_dir = ale#path#Dirname(l:json_file)
+        let l:build_dir = ale#c#FindCompileCommands(a:buffer)
     endif
 
     " The extra arguments in the command are used to prevent .plist files from
     " being generated. These are only added if no build directory can be
     " detected.
-    return '%e -analyze %s'
-    \   . (empty(l:build_dir) ? ' --extra-arg=-Xclang --extra-arg=-analyzer-output=text --extra-arg=-fno-color-diagnostics': '')
-    \   . ale#Pad(l:user_options)
+    return ale#Escape(ale_linters#cpp#clangcheck#GetExecutable(a:buffer))
+    \   . ' -analyze %s'
+    \   . (!empty(l:user_options) ? ' ' . l:user_options : '')
     \   . (!empty(l:build_dir) ? ' -p ' . ale#Escape(l:build_dir) : '')
+    \   . (empty(l:build_dir) ? ' -extra-arg -Xanalyzer -extra-arg -analyzer-output=text' : '')
 endfunction
 
 call ale#linter#Define('cpp', {
 \   'name': 'clangcheck',
 \   'output_stream': 'stderr',
-\   'executable': {b -> ale#Var(b, 'cpp_clangcheck_executable')},
-\   'command': function('ale_linters#cpp#clangcheck#GetCommand'),
+\   'executable_callback': 'ale_linters#cpp#clangcheck#GetExecutable',
+\   'command_callback': 'ale_linters#cpp#clangcheck#GetCommand',
 \   'callback': 'ale#handlers#gcc#HandleGCCFormat',
 \   'lint_file': 1,
 \})

ale_linters/cpp/clangd.vim

@@ -1,22 +0,0 @@
-" Author: Andrey Melentyev <andrey.melentyev@protonmail.com>
-" Description: Clangd language server
-
-call ale#Set('cpp_clangd_executable', 'clangd')
-call ale#Set('cpp_clangd_options', '')
-call ale#Set('c_build_dir', '')
-
-function! ale_linters#cpp#clangd#GetCommand(buffer) abort
-    let l:build_dir = ale#c#GetBuildDirectory(a:buffer)
-
-    return '%e'
-    \    . ale#Pad(ale#Var(a:buffer, 'cpp_clangd_options'))
-    \    . (!empty(l:build_dir) ? ' -compile-commands-dir=' . ale#Escape(l:build_dir) : '')
-endfunction
-
-call ale#linter#Define('cpp', {
-\   'name': 'clangd',
-\   'lsp': 'stdio',
-\   'executable': {b -> ale#Var(b, 'cpp_clangd_executable')},
-\   'command': function('ale_linters#cpp#clangd#GetCommand'),
-\   'project_root': function('ale#c#FindProjectRoot'),
-\})

ale_linters/cpp/clangtidy.vim

@@ -4,40 +4,45 @@
 
 call ale#Set('cpp_clangtidy_executable', 'clang-tidy')
 " Set this option to check the checks clang-tidy will apply.
-call ale#Set('cpp_clangtidy_checks', [])
-" Set this option to manually set some options for clang-tidy to use as compile
-" flags.
+call ale#Set('cpp_clangtidy_checks', ['*'])
+" Set this option to manually set some options for clang-tidy.
 " This will disable compile_commands.json detection.
 call ale#Set('cpp_clangtidy_options', '')
-" Set this option to manually set options for clang-tidy directly.
-call ale#Set('cpp_clangtidy_extra_options', '')
 call ale#Set('c_build_dir', '')
 
-function! ale_linters#cpp#clangtidy#GetCommand(buffer, output) abort
-    let l:checks = join(ale#Var(a:buffer, 'cpp_clangtidy_checks'), ',')
-    let l:build_dir = ale#c#GetBuildDirectory(a:buffer)
-    let l:options = ''
+function! ale_linters#cpp#clangtidy#GetExecutable(buffer) abort
+    return ale#Var(a:buffer, 'cpp_clangtidy_executable')
+endfunction
 
-    " Get the extra options if we couldn't find a build directory.
-    if empty(l:build_dir)
-        let l:options = ale#Var(a:buffer, 'cpp_clangtidy_options')
-        let l:cflags = ale#c#GetCFlags(a:buffer, a:output)
-        let l:options .= !empty(l:options) ? ale#Pad(l:cflags) : l:cflags
-
-        " Tell clang-tidy a .h header with a C++ filetype in Vim is a C++ file
-        " only when compile-commands.json file is not there. Adding these
-        " flags makes clang-tidy completely ignore compile commmands.
-        if expand('#' . a:buffer) =~# '\.h$'
-            let l:options .= !empty(l:options) ? ' -x c++' : '-x c++'
-        endif
+function! s:GetBuildDirectory(buffer) abort
+    " Don't include build directory for header files, as compile_commands.json
+    " files don't consider headers to be translation units, and provide no
+    " commands for compiling header files.
+    if expand('#' . a:buffer) =~# '\v\.(h|hpp)$'
+        return ''
     endif
 
-    " Get the options to pass directly to clang-tidy
-    let l:extra_options = ale#Var(a:buffer, 'cpp_clangtidy_extra_options')
+    let l:build_dir = ale#Var(a:buffer, 'c_build_dir')
 
-    return '%e'
+    " c_build_dir has the priority if defined
+    if !empty(l:build_dir)
+        return l:build_dir
+    endif
+
+    return ale#c#FindCompileCommands(a:buffer)
+endfunction
+
+function! ale_linters#cpp#clangtidy#GetCommand(buffer) abort
+    let l:checks = join(ale#Var(a:buffer, 'cpp_clangtidy_checks'), ',')
+    let l:build_dir = s:GetBuildDirectory(a:buffer)
+
+    " Get the extra options if we couldn't find a build directory.
+    let l:options = empty(l:build_dir)
+    \   ? ale#Var(a:buffer, 'cpp_clangtidy_options')
+    \   : ''
+
+    return ale#Escape(ale_linters#cpp#clangtidy#GetExecutable(a:buffer))
     \   . (!empty(l:checks) ? ' -checks=' . ale#Escape(l:checks) : '')
-    \   . (!empty(l:extra_options) ? ' ' . ale#Escape(l:extra_options) : '')
     \   . ' %s'
     \   . (!empty(l:build_dir) ? ' -p ' . ale#Escape(l:build_dir) : '')
     \   . (!empty(l:options) ? ' -- ' . l:options : '')
@@ -46,8 +51,8 @@ endfunction
 call ale#linter#Define('cpp', {
 \   'name': 'clangtidy',
 \   'output_stream': 'stdout',
-\   'executable': {b -> ale#Var(b, 'cpp_clangtidy_executable')},
-\   'command': {b -> ale#c#RunMakeCommand(b, function('ale_linters#cpp#clangtidy#GetCommand'))},
+\   'executable_callback': 'ale_linters#cpp#clangtidy#GetExecutable',
+\   'command_callback': 'ale_linters#cpp#clangtidy#GetCommand',
 \   'callback': 'ale#handlers#gcc#HandleGCCFormat',
 \   'lint_file': 1,
 \})

ale_linters/cpp/clazy.vim

@@ -1,32 +0,0 @@
-" Description: clazy linter for cpp files (clang-based and Qt-oriented)
-
-call ale#Set('cpp_clazy_executable', 'clazy-standalone')
-" Set this option to check the checks clazy will apply.
-call ale#Set('cpp_clazy_checks', ['level1'])
-" Set this option to manually set some options for clazy.
-" This will disable compile_commands.json detection.
-call ale#Set('cpp_clazy_options', '')
-call ale#Set('c_build_dir', '')
-
-function! ale_linters#cpp#clazy#GetCommand(buffer) abort
-    let l:checks = join(ale#Var(a:buffer, 'cpp_clazy_checks'), ',')
-    let l:build_dir = ale#c#GetBuildDirectory(a:buffer)
-
-    " Get the extra options if we couldn't find a build directory.
-    let l:options = ale#Var(a:buffer, 'cpp_clazy_options')
-
-    return '%e'
-    \   . (!empty(l:checks) ? ' -checks=' . ale#Escape(l:checks) : '')
-    \   . (!empty(l:build_dir) ? ' -p ' . ale#Escape(l:build_dir) : '')
-    \   . (!empty(l:options) ? ' ' . l:options : '')
-    \   . ' %s'
-endfunction
-
-call ale#linter#Define('cpp', {
-\   'name': 'clazy',
-\   'output_stream': 'stderr',
-\   'executable': {b -> ale#Var(b, 'cpp_clazy_executable')},
-\   'command': function('ale_linters#cpp#clazy#GetCommand'),
-\   'callback': 'ale#handlers#gcc#HandleGCCFormat',
-\   'lint_file': 1,
-\})

ale_linters/cpp/cppcheck.vim

@@ -4,26 +4,36 @@
 call ale#Set('cpp_cppcheck_executable', 'cppcheck')
 call ale#Set('cpp_cppcheck_options', '--enable=style')
 
-function! ale_linters#cpp#cppcheck#GetCommand(buffer) abort
-    let l:compile_commands_option = ale#handlers#cppcheck#GetCompileCommandsOptions(a:buffer)
-    let l:buffer_path_include = empty(l:compile_commands_option)
-    \   ? ale#handlers#cppcheck#GetBufferPathIncludeOptions(a:buffer)
-    \   : ''
-    let l:template = ' --template=' . ale#Escape('{file}:{line}:{column}: {severity}:{inconclusive:inconclusive:} {message} [{id}]\\n{code}')
+function! ale_linters#cpp#cppcheck#GetExecutable(buffer) abort
+    return ale#Var(a:buffer, 'cpp_cppcheck_executable')
+endfunction
 
-    return '%e -q --language=c++'
-    \   . l:template
-    \   . ale#Pad(l:compile_commands_option)
-    \   . ale#Pad(ale#Var(a:buffer, 'cpp_cppcheck_options'))
-    \   . l:buffer_path_include
+function! ale_linters#cpp#cppcheck#GetCommand(buffer) abort
+    " Search upwards from the file for compile_commands.json.
+    "
+    " If we find it, we'll `cd` to where the compile_commands.json file is,
+    " then use the file to set up import paths, etc.
+    let l:compile_commmands_path = ale#path#FindNearestFile(a:buffer, 'compile_commands.json')
+
+    let l:cd_command = !empty(l:compile_commmands_path)
+    \   ? ale#path#CdString(fnamemodify(l:compile_commmands_path, ':h'))
+    \   : ''
+    let l:compile_commands_option = !empty(l:compile_commmands_path)
+    \   ? '--project=compile_commands.json '
+    \   : ''
+
+    return l:cd_command
+    \   . ale#Escape(ale_linters#cpp#cppcheck#GetExecutable(a:buffer))
+    \   . ' -q --language=c++ '
+    \   . l:compile_commands_option
+    \   . ale#Var(a:buffer, 'cpp_cppcheck_options')
     \   . ' %t'
 endfunction
 
 call ale#linter#Define('cpp', {
 \   'name': 'cppcheck',
 \   'output_stream': 'both',
-\   'executable': {b -> ale#Var(b, 'cpp_cppcheck_executable')},
-\   'cwd': function('ale#handlers#cppcheck#GetCwd'),
-\   'command': function('ale_linters#cpp#cppcheck#GetCommand'),
+\   'executable_callback': 'ale_linters#cpp#cppcheck#GetExecutable',
+\   'command_callback': 'ale_linters#cpp#cppcheck#GetCommand',
 \   'callback': 'ale#handlers#cppcheck#HandleCppCheckFormat',
 \})

ale_linters/cpp/cpplint.vim

@@ -4,17 +4,23 @@
 call ale#Set('cpp_cpplint_executable', 'cpplint')
 call ale#Set('cpp_cpplint_options', '')
 
+function! ale_linters#cpp#cpplint#GetExecutable(buffer) abort
+    return ale#Var(a:buffer, 'cpp_cpplint_executable')
+endfunction
+
 function! ale_linters#cpp#cpplint#GetCommand(buffer) abort
     let l:options = ale#Var(a:buffer, 'cpp_cpplint_options')
 
-    return '%e' . ale#Pad(l:options) . ' %s'
+    return ale#Escape(ale_linters#cpp#cpplint#GetExecutable(a:buffer))
+    \   . (!empty(l:options) ? ' ' . l:options : '')
+    \   . ' %s'
 endfunction
 
 call ale#linter#Define('cpp', {
 \   'name': 'cpplint',
 \   'output_stream': 'stderr',
-\   'executable': {b -> ale#Var(b, 'cpp_cpplint_executable')},
-\   'command': function('ale_linters#cpp#cpplint#GetCommand'),
+\   'executable_callback': 'ale_linters#cpp#cpplint#GetExecutable',
+\   'command_callback': 'ale_linters#cpp#cpplint#GetCommand',
 \   'callback': 'ale#handlers#cpplint#HandleCppLintFormat',
 \   'lint_file': 1,
 \})

ale_linters/cpp/cquery.vim

@@ -1,30 +0,0 @@
-" Author: Ben Falconer <ben@falconers.me.uk>
-" Description: A language server for C++
-
-call ale#Set('cpp_cquery_executable', 'cquery')
-call ale#Set('cpp_cquery_cache_directory', expand('~/.cache/cquery'))
-
-function! ale_linters#cpp#cquery#GetProjectRoot(buffer) abort
-    " Try to find cquery configuration files first.
-    let l:config = ale#path#FindNearestFile(a:buffer, '.cquery')
-
-    if !empty(l:config)
-        return fnamemodify(l:config, ':h')
-    endif
-
-    " Fall back on default project root detection.
-    return ale#c#FindProjectRoot(a:buffer)
-endfunction
-
-function! ale_linters#cpp#cquery#GetInitializationOptions(buffer) abort
-    return {'cacheDirectory': ale#Var(a:buffer, 'cpp_cquery_cache_directory')}
-endfunction
-
-call ale#linter#Define('cpp', {
-\   'name': 'cquery',
-\   'lsp': 'stdio',
-\   'executable': {b -> ale#Var(b, 'cpp_cquery_executable')},
-\   'command': '%e',
-\   'project_root': function('ale_linters#cpp#cquery#GetProjectRoot'),
-\   'initialization_options': function('ale_linters#cpp#cquery#GetInitializationOptions'),
-\})

ale_linters/cpp/cspell.vim

@@ -1,5 +0,0 @@
-scriptencoding utf-8
-" Author: David Houston <houstdav000>
-" Description: cspell support for C++ files.
-
-call ale#handlers#cspell#DefineLinter('cpp')

ale_linters/cpp/flawfinder.vim

@@ -1,25 +0,0 @@
-" Author: Christian Gibbons <cgibbons@gmu.edu>
-" Description: flawfinder linter for c++ files
-
-call ale#Set('cpp_flawfinder_executable', 'flawfinder')
-call ale#Set('cpp_flawfinder_options', '')
-call ale#Set('cpp_flawfinder_minlevel', 1)
-call ale#Set('c_flawfinder_error_severity', 6)
-
-function! ale_linters#cpp#flawfinder#GetCommand(buffer) abort
-    " Set the minimum vulnerability level for flawfinder to bother with
-    let l:minlevel = ' --minlevel=' . ale#Var(a:buffer, 'cpp_flawfinder_minlevel')
-
-    return '%e -CDQS'
-    \  . ale#Var(a:buffer, 'cpp_flawfinder_options')
-    \  . l:minlevel
-    \  . ' %t'
-endfunction
-
-call ale#linter#Define('cpp', {
-\  'name': 'flawfinder',
-\  'output_stream': 'stdout',
-\  'executable': {b -> ale#Var(b, 'cpp_flawfinder_executable')},
-\  'command': function('ale_linters#cpp#flawfinder#GetCommand'),
-\  'callback': 'ale#handlers#flawfinder#HandleFlawfinderFormat',
-\})

ale_linters/cpp/gcc.vim

@@ -0,0 +1,29 @@
+" Author: geam <mdelage@student.42.fr>
+" Description: gcc linter for cpp files
+"
+call ale#Set('cpp_gcc_executable', 'gcc')
+call ale#Set('cpp_gcc_options', '-std=c++14 -Wall')
+
+function! ale_linters#cpp#gcc#GetExecutable(buffer) abort
+    return ale#Var(a:buffer, 'cpp_gcc_executable')
+endfunction
+
+function! ale_linters#cpp#gcc#GetCommand(buffer) abort
+    let l:paths = ale#c#FindLocalHeaderPaths(a:buffer)
+
+    " -iquote with the directory the file is in makes #include work for
+    "  headers in the same directory.
+    return ale#Escape(ale_linters#cpp#gcc#GetExecutable(a:buffer))
+    \   . ' -S -x c++ -fsyntax-only '
+    \   . '-iquote ' . ale#Escape(fnamemodify(bufname(a:buffer), ':p:h')) . ' '
+    \   . ale#c#IncludeOptions(l:paths)
+    \   . ale#Var(a:buffer, 'cpp_gcc_options') . ' -'
+endfunction
+
+call ale#linter#Define('cpp', {
+\   'name': 'g++',
+\   'output_stream': 'stderr',
+\   'executable_callback': 'ale_linters#cpp#gcc#GetExecutable',
+\   'command_callback': 'ale_linters#cpp#gcc#GetCommand',
+\   'callback': 'ale#handlers#gcc#HandleGCCFormat',
+\})

ale_linters/crystal/ameba.vim

@@ -1,57 +0,0 @@
-" Author: Harrison Bachrach - https://github.com/HarrisonB
-" Description: Ameba, a linter for crystal files
-
-call ale#Set('crystal_ameba_executable', 'bin/ameba')
-
-function! ale_linters#crystal#ameba#GetCommand(buffer) abort
-    let l:executable = ale#Var(a:buffer, 'crystal_ameba_executable')
-
-    return ale#Escape(l:executable)
-    \   . ' --format json '
-    \   .  ale#Escape(expand('#' . a:buffer . ':p'))
-endfunction
-
-" Handle output from ameba
-function! ale_linters#crystal#ameba#HandleAmebaOutput(buffer, lines) abort
-    if len(a:lines) == 0
-        return []
-    endif
-
-    let l:errors = ale#util#FuzzyJSONDecode(a:lines[0], {})
-
-    if !has_key(l:errors, 'summary')
-    \|| l:errors['summary']['issues_count'] == 0
-    \|| empty(l:errors['sources'])
-        return []
-    endif
-
-    let l:output = []
-
-    for l:error in l:errors['sources'][0]['issues']
-        let l:start_col = str2nr(l:error['location']['column'])
-        let l:end_col = str2nr(l:error['end_location']['column'])
-
-        if !l:end_col
-            let l:end_col = l:start_col + 1
-        endif
-
-        call add(l:output, {
-        \   'lnum': str2nr(l:error['location']['line']),
-        \   'col': l:start_col,
-        \   'end_col': l:end_col,
-        \   'code': l:error['rule_name'],
-        \   'text': l:error['message'],
-        \   'type': 'W',
-        \})
-    endfor
-
-    return l:output
-endfunction
-
-call ale#linter#Define('crystal', {
-\   'name': 'ameba',
-\   'executable': {b -> ale#Var(b, 'crystal_ameba_executable')},
-\   'command': function('ale_linters#crystal#ameba#GetCommand'),
-\   'callback': 'ale_linters#crystal#ameba#HandleAmebaOutput',
-\   'lint_file': 1,
-\})

ale_linters/crystal/crystal.vim

@@ -5,10 +5,6 @@ function! ale_linters#crystal#crystal#Handle(buffer, lines) abort
     let l:output = []
 
     for l:error in ale#util#FuzzyJSONDecode(a:lines, [])
-        if !has_key(l:error, 'file')
-            continue
-        endif
-
         call add(l:output, {
         \   'lnum': l:error.line + 0,
         \   'col': l:error.column + 0,
@@ -30,6 +26,6 @@ call ale#linter#Define('crystal', {
 \   'executable': 'crystal',
 \   'output_stream': 'both',
 \   'lint_file': 1,
-\   'command': function('ale_linters#crystal#crystal#GetCommand'),
+\   'command_callback': 'ale_linters#crystal#crystal#GetCommand',
 \   'callback': 'ale_linters#crystal#crystal#Handle',
 \})

ale_linters/cs/csc.vim

@@ -1,90 +0,0 @@
-call ale#Set('cs_csc_options', '')
-call ale#Set('cs_csc_source', '')
-call ale#Set('cs_csc_assembly_path', [])
-call ale#Set('cs_csc_assemblies', [])
-
-function! ale_linters#cs#csc#GetCwd(buffer) abort
-    let l:cwd = ale#Var(a:buffer, 'cs_csc_source')
-
-    return !empty(l:cwd) ? l:cwd : expand('#' . a:buffer . ':p:h')
-endfunction
-
-function! ale_linters#cs#csc#GetCommand(buffer) abort
-    " Pass assembly paths via the -lib: parameter.
-    let l:path_list = ale#Var(a:buffer, 'cs_csc_assembly_path')
-
-    let l:lib_option = !empty(l:path_list)
-    \   ? '/lib:' . join(map(copy(l:path_list), 'ale#Escape(v:val)'), ',')
-    \   : ''
-
-    " Pass paths to DLL files via the -r: parameter.
-    let l:assembly_list = ale#Var(a:buffer, 'cs_csc_assemblies')
-
-    let l:r_option = !empty(l:assembly_list)
-    \   ? '/r:' . join(map(copy(l:assembly_list), 'ale#Escape(v:val)'), ',')
-    \   : ''
-
-    " register temporary module target file with ale
-    " register temporary module target file with ALE.
-    let l:out = ale#command#CreateFile(a:buffer)
-
-    " The code is compiled as a module and the output is redirected to a
-    " temporary file.
-    return 'csc /unsafe'
-    \    . ale#Pad(ale#Var(a:buffer, 'cs_csc_options'))
-    \    . ale#Pad(l:lib_option)
-    \    . ale#Pad(l:r_option)
-    \    . ' /out:' . l:out
-    \    . ' /t:module'
-    \    . ' /recurse:' . ale#Escape('*.cs')
-endfunction
-
-function! ale_linters#cs#csc#Handle(buffer, lines) abort
-    " Look for lines like the following.
-    "
-    " Tests.cs(12,29): error CSXXXX: ; expected
-    "
-    " NOTE: pattern also captures file name as linter compiles all
-    " files within the source tree rooted at the specified source
-    " path and not just the file loaded in the buffer
-    let l:patterns = [
-    \    '^\v(.+\.cs)\((\d+),(\d+)\)\:\s+([^ ]+)\s+([cC][sS][^ ]+):\s(.+)$',
-    \    '^\v([^ ]+)\s+([Cc][sS][^ ]+):\s+(.+)$',
-    \]
-    let l:output = []
-    let l:dir = ale_linters#cs#csc#GetCwd(a:buffer)
-
-    for l:match in ale#util#GetMatches(a:lines, l:patterns)
-        if len(l:match) > 6 && strlen(l:match[5]) > 2 && l:match[5][:1] is? 'CS'
-            call add(l:output, {
-            \   'filename': ale#path#GetAbsPath(l:dir, l:match[1]),
-            \   'lnum': l:match[2] + 0,
-            \   'col': l:match[3] + 0,
-            \   'type': l:match[4] is# 'error' ? 'E' : 'W',
-            \   'code': l:match[5],
-            \   'text': l:match[6] ,
-            \})
-        elseif strlen(l:match[2]) > 2 && l:match[2][:1] is? 'CS'
-            call add(l:output, {
-            \   'filename':'<csc>',
-            \   'lnum': -1,
-            \   'col': -1,
-            \   'type': l:match[1] is# 'error' ? 'E' : 'W',
-            \   'code': l:match[2],
-            \   'text': l:match[3],
-            \})
-        endif
-    endfor
-
-    return l:output
-endfunction
-
-call ale#linter#Define('cs',{
-\   'name': 'csc',
-\   'output_stream': 'stdout',
-\   'executable': 'csc',
-\   'cwd': function('ale_linters#cs#csc#GetCwd'),
-\   'command': function('ale_linters#cs#csc#GetCommand'),
-\   'callback': 'ale_linters#cs#csc#Handle',
-\   'lint_file': 1
-\})

ale_linters/cs/cspell.vim

@@ -1,5 +0,0 @@
-scriptencoding utf-8
-" Author: David Houston <houstdav000>
-" Description: cspell support for C# files.
-
-call ale#handlers#cspell#DefineLinter('cs')

ale_linters/cs/mcs.vim

@@ -1,27 +1,22 @@
 let g:ale_cs_mcs_options = get(g:, 'ale_cs_mcs_options', '')
 
 function! ale_linters#cs#mcs#GetCommand(buffer) abort
-    let l:options = ale#Var(a:buffer, 'cs_mcs_options')
-
-    return 'mcs -unsafe --parse'
-    \   . (!empty(l:options) ? ' ' . l:options : '')
-    \   . ' %t'
+    return 'mcs -unsafe --parse ' . ale#Var(a:buffer, 'cs_mcs_options') . ' %t'
 endfunction
 
 function! ale_linters#cs#mcs#Handle(buffer, lines) abort
     " Look for lines like the following.
     "
     " Tests.cs(12,29): error CSXXXX: ; expected
-    let l:pattern = '^\v(.+\.cs)\((\d+),(\d+)\)\: ([^ ]+) ([^ ]+): (.+)$'
+    let l:pattern = '^.\+.cs(\(\d\+\),\(\d\+\)): \(.\+\): \(.\+\)'
     let l:output = []
 
     for l:match in ale#util#GetMatches(a:lines, l:pattern)
         call add(l:output, {
-        \   'lnum': l:match[2] + 0,
-        \   'col': l:match[3] + 0,
-        \   'type': l:match[4] is# 'error' ? 'E' : 'W',
-        \   'code': l:match[5],
-        \   'text': l:match[6],
+        \   'lnum': l:match[1] + 0,
+        \   'col': l:match[2] + 0,
+        \   'text': l:match[3] . ': ' . l:match[4],
+        \   'type': l:match[3] =~# '^error' ? 'E' : 'W',
         \})
     endfor
 
@@ -32,6 +27,6 @@ call ale#linter#Define('cs',{
 \   'name': 'mcs',
 \   'output_stream': 'stderr',
 \   'executable': 'mcs',
-\   'command': function('ale_linters#cs#mcs#GetCommand'),
+\   'command_callback': 'ale_linters#cs#mcs#GetCommand',
 \   'callback': 'ale_linters#cs#mcs#Handle',
 \})

ale_linters/cs/mcsc.vim

@@ -1,42 +1,55 @@
-call ale#Set('cs_mcsc_options', '')
-call ale#Set('cs_mcsc_source', '')
-call ale#Set('cs_mcsc_assembly_path', [])
-call ale#Set('cs_mcsc_assemblies', [])
+" general mcs options which are likely to stay constant across
+" source trees like -pkg:dotnet
+let g:ale_cs_mcsc_options = get(g:, 'ale_cs_mcsc_options', '')
 
-function! ale_linters#cs#mcsc#GetCwd(buffer) abort
-    let l:cwd = ale#Var(a:buffer, 'cs_mcsc_source')
+" path string pointing the linter to the base path of the
+" source tree to check
+let g:ale_cs_mcsc_source = get(g:, 'ale_cs_mcsc_source','.')
 
-    return !empty(l:cwd) ? l:cwd : expand('#' . a:buffer . ':p:h')
-endfunction
+" list of search paths for additional assemblies to consider
+let g:ale_cs_mcsc_assembly_path = get(g:, 'ale_cs_mcsc_assembly_path',[])
 
+" list of assemblies to consider
+let g:ale_cs_mcsc_assemblies = get(g:, 'ale_cs_mcsc_assemblies',[])
 function! ale_linters#cs#mcsc#GetCommand(buffer) abort
-    " Pass assembly paths via the -lib: parameter.
-    let l:path_list = ale#Var(a:buffer, 'cs_mcsc_assembly_path')
 
-    let l:lib_option = !empty(l:path_list)
-    \   ? '-lib:' . join(map(copy(l:path_list), 'ale#Escape(v:val)'), ',')
-    \   : ''
+    " if list of assembly search paths is not empty convert it to
+    " appropriate -lib: parameter of mcs
+    let l:path = ale#Var(a:buffer, 'cs_mcsc_assembly_path')
 
-    " Pass paths to DLL files via the -r: parameter.
-    let l:assembly_list = ale#Var(a:buffer, 'cs_mcsc_assemblies')
+    if !empty(l:path)
+         let l:path = '-lib:"' . join(l:path, '","') .'"'
+    else
+        let l:path =''
+    endif
 
-    let l:r_option = !empty(l:assembly_list)
-    \   ? '-r:' . join(map(copy(l:assembly_list), 'ale#Escape(v:val)'), ',')
-    \   : ''
+    " if list of assemblies to link is not empty convert it to the
+    " appropriate -r: parameter of mcs
+    let l:assemblies = ale#Var(a:buffer, 'cs_mcsc_assemblies')
+
+    if !empty(l:assemblies)
+        let l:assemblies = '-r:"' . join(l:assemblies, '","') . '"'
+    else
+        let l:assemblies =''
+    endif
 
     " register temporary module target file with ale
-    " register temporary module target file with ALE.
-    let l:out = ale#command#CreateFile(a:buffer)
+    let l:out = tempname()
+    call ale#engine#ManageFile(a:buffer, l:out)
 
-    " The code is compiled as a module and the output is redirected to a
-    " temporary file.
-    return 'mcs -unsafe'
-    \    . ale#Pad(ale#Var(a:buffer, 'cs_mcsc_options'))
-    \    . ale#Pad(l:lib_option)
-    \    . ale#Pad(l:r_option)
+    " assemble linter command string to be executed by ale
+    " implicitly set -unsafe mcs flag set compilation
+    " target to module (-t:module), direct mcs output to
+    " temporary file (-out)
+    "
+    return 'cd "' . ale#Var(a:buffer, 'cs_mcsc_source') . '";'
+    \    . 'mcs -unsafe'
+    \    . ' ' . ale#Var(a:buffer, 'cs_mcsc_options')
+    \    . ' ' . l:path
+    \    . ' ' . l:assemblies
     \    . ' -out:' . l:out
     \    . ' -t:module'
-    \    . ' -recurse:' . ale#Escape('*.cs')
+    \    . ' -recurse:"*.cs"'
 endfunction
 
 function! ale_linters#cs#mcsc#Handle(buffer, lines) abort
@@ -47,34 +60,18 @@ function! ale_linters#cs#mcsc#Handle(buffer, lines) abort
     " NOTE: pattern also captures file name as linter compiles all
     " files within the source tree rooted at the specified source
     " path and not just the file loaded in the buffer
-    let l:patterns = [
-    \    '^\v(.+\.cs)\((\d+),(\d+)\)\:\s+([^ ]+)\s+([cC][sS][^ ]+):\s(.+)$',
-    \    '^\v([^ ]+)\s+([Cc][sS][^ ]+):\s+(.+)$',
-    \]
+    let l:pattern = '^\(.\+\.cs\)(\(\d\+\),\(\d\+\)): \(.\+\): \(.\+\)'
     let l:output = []
+    let l:source = ale#Var(a:buffer, 'cs_mcsc_source')
 
-    let l:dir = ale_linters#cs#mcsc#GetCwd(a:buffer)
-
-    for l:match in ale#util#GetMatches(a:lines, l:patterns)
-        if len(l:match) > 6 && strlen(l:match[5]) > 2 && l:match[5][:1] is? 'CS'
-            call add(l:output, {
-            \   'filename': ale#path#GetAbsPath(l:dir, l:match[1]),
-            \   'lnum': l:match[2] + 0,
-            \   'col': l:match[3] + 0,
-            \   'type': l:match[4] is# 'error' ? 'E' : 'W',
-            \   'code': l:match[5],
-            \   'text': l:match[6] ,
-            \})
-        elseif strlen(l:match[2]) > 2 && l:match[2][:1] is? 'CS'
-            call add(l:output, {
-            \   'filename':'<mcs>',
-            \   'lnum': -1,
-            \   'col': -1,
-            \   'type': l:match[1] is# 'error' ? 'E' : 'W',
-            \   'code': l:match[2],
-            \   'text': l:match[3],
-            \})
-        endif
+    for l:match in ale#util#GetMatches(a:lines, l:pattern)
+        call add(l:output, {
+        \   'filename': fnamemodify(l:source . '/' . l:match[1], ':p'),
+        \   'lnum': l:match[2] + 0,
+        \   'col': l:match[3] + 0,
+        \   'text': l:match[4] . ': ' . l:match[5],
+        \   'type': l:match[4] =~# '^error' ? 'E' : 'W',
+        \})
     endfor
 
     return l:output
@@ -84,8 +81,7 @@ call ale#linter#Define('cs',{
 \   'name': 'mcsc',
 \   'output_stream': 'stderr',
 \   'executable': 'mcs',
-\   'cwd': function('ale_linters#cs#mcsc#GetCwd'),
-\   'command': function('ale_linters#cs#mcsc#GetCommand'),
+\   'command_callback': 'ale_linters#cs#mcsc#GetCommand',
 \   'callback': 'ale_linters#cs#mcsc#Handle',
 \   'lint_file': 1
 \})

ale_linters/css/cspell.vim

@@ -1,5 +0,0 @@
-scriptencoding utf-8
-" Author: David Houston <houstdav000>
-" Description: cspell support for CSS files.
-
-call ale#handlers#cspell#DefineLinter('css')

ale_linters/css/csslint.vim

@@ -13,6 +13,6 @@ endfunction
 call ale#linter#Define('css', {
 \   'name': 'csslint',
 \   'executable': 'csslint',
-\   'command': function('ale_linters#css#csslint#GetCommand'),
+\   'command_callback': 'ale_linters#css#csslint#GetCommand',
 \   'callback': 'ale#handlers#css#HandleCSSLintFormat',
 \})

ale_linters/css/fecs.vim

@@ -1,9 +0,0 @@
-" Author: harttle <yangjvn@126.com>
-" Description: fecs for CSS files
-
-call ale#linter#Define('css', {
-\   'name': 'fecs',
-\   'executable': function('ale#handlers#fecs#GetExecutable'),
-\   'command': function('ale#handlers#fecs#GetCommand'),
-\   'callback': 'ale#handlers#fecs#Handle',
-\})

ale_linters/css/stylelint.vim

@@ -2,18 +2,23 @@
 
 call ale#Set('css_stylelint_executable', 'stylelint')
 call ale#Set('css_stylelint_options', '')
-call ale#Set('css_stylelint_use_global', get(g:, 'ale_use_global_executables', 0))
+call ale#Set('css_stylelint_use_global', 0)
+
+function! ale_linters#css#stylelint#GetExecutable(buffer) abort
+    return ale#node#FindExecutable(a:buffer, 'css_stylelint', [
+    \   'node_modules/.bin/stylelint',
+    \])
+endfunction
 
 function! ale_linters#css#stylelint#GetCommand(buffer) abort
-    return '%e ' . ale#Pad(ale#Var(a:buffer, 'css_stylelint_options'))
+    return ale_linters#css#stylelint#GetExecutable(a:buffer)
+    \   . ' ' . ale#Var(a:buffer, 'css_stylelint_options')
     \   . ' --stdin-filename %s'
 endfunction
 
 call ale#linter#Define('css', {
 \   'name': 'stylelint',
-\   'executable': {b -> ale#path#FindExecutable(b, 'css_stylelint', [
-\       'node_modules/.bin/stylelint',
-\   ])},
-\   'command': function('ale_linters#css#stylelint#GetCommand'),
+\   'executable_callback': 'ale_linters#css#stylelint#GetExecutable',
+\   'command_callback': 'ale_linters#css#stylelint#GetCommand',
 \   'callback': 'ale#handlers#css#HandleStyleLintFormat',
 \})

ale_linters/css/vscodecss.vim

@@ -1,16 +0,0 @@
-" Author: Dalius Dobravolskas <dalius.dobravolskas@gmail.com>
-" Description: VSCode css language server
-
-function! ale_linters#css#vscodecss#GetProjectRoot(buffer) abort
-    let l:git_path = ale#path#FindNearestDirectory(a:buffer, '.git')
-
-    return !empty(l:git_path) ? fnamemodify(l:git_path, ':h:h') : ''
-endfunction
-
-call ale#linter#Define('css', {
-\   'name': 'vscodecss',
-\   'lsp': 'stdio',
-\   'executable': 'vscode-css-language-server',
-\   'command': '%e --stdio',
-\   'project_root': function('ale_linters#css#vscodecss#GetProjectRoot'),
-\})

ale_linters/cucumber/cucumber.vim

@@ -1,46 +0,0 @@
-" Author: Eddie Lebow https://github.com/elebow
-" Description: Cucumber, a BDD test tool
-
-function! ale_linters#cucumber#cucumber#GetCommand(buffer) abort
-    let l:features_dir = ale#path#FindNearestDirectory(a:buffer, 'features')
-
-    if !empty(l:features_dir)
-        let l:features_arg = '-r ' . ale#Escape(l:features_dir)
-    else
-        let l:features_arg = ''
-    endif
-
-    return 'cucumber --dry-run --quiet --strict --format=json '
-    \   . l:features_arg . ' %t'
-endfunction
-
-function! ale_linters#cucumber#cucumber#Handle(buffer, lines) abort
-    try
-        let l:json = ale#util#FuzzyJSONDecode(a:lines, {})[0]
-    catch
-        return []
-    endtry
-
-    let l:output = []
-
-    for l:element in get(l:json, 'elements', [])
-        for l:step in l:element['steps']
-            if l:step['result']['status'] is# 'undefined'
-                call add(l:output, {
-                \   'lnum': l:step['line'],
-                \   'code': 'E',
-                \   'text': 'Undefined step'
-                \})
-            endif
-        endfor
-    endfor
-
-    return l:output
-endfunction
-
-call ale#linter#Define('cucumber', {
-\   'name': 'cucumber',
-\   'executable': 'cucumber',
-\   'command': function('ale_linters#cucumber#cucumber#GetCommand'),
-\   'callback': 'ale_linters#cucumber#cucumber#Handle'
-\})

ale_linters/cuda/clangd.vim

@@ -1,23 +0,0 @@
-" Author: Tommy Chiang <ty1208chiang@gmail.com>
-" Description: Clangd language server for CUDA (modified from Andrey
-" Melentyev's implementation for C++)
-
-call ale#Set('cuda_clangd_executable', 'clangd')
-call ale#Set('cuda_clangd_options', '')
-call ale#Set('c_build_dir', '')
-
-function! ale_linters#cuda#clangd#GetCommand(buffer) abort
-    let l:build_dir = ale#c#GetBuildDirectory(a:buffer)
-
-    return '%e'
-    \    . ale#Pad(ale#Var(a:buffer, 'cuda_clangd_options'))
-    \    . (!empty(l:build_dir) ? ' -compile-commands-dir=' . ale#Escape(l:build_dir) : '')
-endfunction
-
-call ale#linter#Define('cuda', {
-\   'name': 'clangd',
-\   'lsp': 'stdio',
-\   'executable': {b -> ale#Var(b, 'cuda_clangd_executable')},
-\   'command': function('ale_linters#cuda#clangd#GetCommand'),
-\   'project_root': function('ale#c#FindProjectRoot'),
-\})

ale_linters/cuda/nvcc.vim

@@ -4,11 +4,20 @@
 call ale#Set('cuda_nvcc_executable', 'nvcc')
 call ale#Set('cuda_nvcc_options', '-std=c++11')
 
+function! ale_linters#cuda#nvcc#GetExecutable(buffer) abort
+    return ale#Var(a:buffer, 'cuda_nvcc_executable')
+endfunction
+
 function! ale_linters#cuda#nvcc#GetCommand(buffer) abort
-    return '%e -cuda'
-    \   . ale#Pad(ale#c#IncludeOptions(ale#c#FindLocalHeaderPaths(a:buffer)))
-    \   . ale#Pad(ale#Var(a:buffer, 'cuda_nvcc_options'))
-    \   . ' %s -o ' . g:ale#util#nul_file
+    " Unused: use ale#util#nul_file
+    " let l:output_file = tempname() . '.ii'
+    " call ale#engine#ManageFile(a:buffer, l:output_file)
+
+    return ale#Escape(ale_linters#cuda#nvcc#GetExecutable(a:buffer))
+    \   . ' -cuda '
+    \   . ale#c#IncludeOptions(ale#c#FindLocalHeaderPaths(a:buffer))
+    \   . ale#Var(a:buffer, 'cuda_nvcc_options') . ' %s'
+    \   . ' -o ' . g:ale#util#nul_file
 endfunction
 
 function! ale_linters#cuda#nvcc#HandleNVCCFormat(buffer, lines) abort
@@ -19,6 +28,7 @@ function! ale_linters#cuda#nvcc#HandleNVCCFormat(buffer, lines) abort
     let l:output = []
 
     for l:match in ale#util#GetMatches(a:lines, l:pattern)
+
         let l:item = {
         \   'lnum': str2nr(l:match[2]),
         \   'type': l:match[4] =~# 'error' ? 'E' : 'W',
@@ -39,8 +49,8 @@ endfunction
 call ale#linter#Define('cuda', {
 \   'name': 'nvcc',
 \   'output_stream': 'stderr',
-\   'executable': {b -> ale#Var(b, 'cuda_nvcc_executable')},
-\   'command': function('ale_linters#cuda#nvcc#GetCommand'),
+\   'executable_callback': 'ale_linters#cuda#nvcc#GetExecutable',
+\   'command_callback': 'ale_linters#cuda#nvcc#GetCommand',
 \   'callback': 'ale_linters#cuda#nvcc#HandleNVCCFormat',
 \   'lint_file': 1,
 \})

ale_linters/cypher/cypher_lint.vim

@@ -1,26 +0,0 @@
-" Author: Francisco Lopes <francisco@oblita.com>
-" Description: Linting for Neo4j's Cypher
-
-function! ale_linters#cypher#cypher_lint#Handle(buffer, lines) abort
-    let l:pattern = '\v^([a-zA-Z]?:?[^:]+):(\d+):(\d+): (.*)$'
-    let l:output = []
-
-    for l:match in ale#util#GetMatches(a:lines, l:pattern)
-        call add(l:output, {
-        \   'lnum': l:match[2] + 0,
-        \   'col': l:match[3] + 0,
-        \   'text': l:match[4],
-        \   'type': 'E',
-        \})
-    endfor
-
-    return l:output
-endfunction
-
-call ale#linter#Define('cypher', {
-\   'name': 'cypher_lint',
-\   'executable': 'cypher-lint',
-\   'command': 'cypher-lint',
-\   'output_stream': 'stderr',
-\   'callback': 'ale_linters#cypher#cypher_lint#Handle',
-\})

ale_linters/d/dls.vim

@@ -1,22 +0,0 @@
-" Author: aurieh <me@aurieh.me>
-" Description: A Language Server implementation for D
-
-call ale#Set('d_dls_executable', 'dls')
-
-function! ale_linters#d#dls#GetExecutable(buffer) abort
-    return ale#Var(a:buffer, 'd_dls_executable')
-endfunction
-
-function! ale_linters#d#dls#FindProjectRoot(buffer) abort
-    " Note: this will return . if dub config is empty
-    " dls can run outside DUB projects just fine
-    return fnamemodify(ale#d#FindDUBConfig(a:buffer), ':h')
-endfunction
-
-call ale#linter#Define('d', {
-\   'name': 'dls',
-\   'lsp': 'stdio',
-\   'executable': function('ale_linters#d#dls#GetExecutable'),
-\   'command': function('ale_linters#d#dls#GetExecutable'),
-\   'project_root': function('ale_linters#d#dls#FindProjectRoot'),
-\})

ale_linters/d/dmd.vim

@@ -1,106 +1,67 @@
 " Author: w0rp <devw0rp@gmail.com>
 " Description: "dmd for D files"
 
-function! s:GetDUBCommand(buffer) abort
-    " If we can't run dub, then skip this command.
-    if executable('dub')
-        " Returning an empty string skips to the DMD command.
-        let l:config = ale#d#FindDUBConfig(a:buffer)
+function! s:FindDUBConfig(buffer) abort
+    " Find a DUB configuration file in ancestor paths.
+    " The most DUB-specific names will be tried first.
+    for l:possible_filename in ['dub.sdl', 'dub.json', 'package.json']
+        let l:dub_file = ale#path#FindNearestFile(a:buffer, l:possible_filename)
 
-        " To support older dub versions, we just change the directory to the
-        " directory where we found the dub config, and then run `dub describe`
-        " from that directory.
-        if !empty(l:config)
-            return [fnamemodify(l:config, ':h'), 'dub describe --data-list
-            \ --data=import-paths
-            \ --data=string-import-paths
-            \ --data=versions
-            \ --data=debug-versions
-            \']
-        endif
-    endif
-
-    return ['', '']
-endfunction
-
-function! ale_linters#d#dmd#RunDUBCommand(buffer) abort
-    let [l:cwd, l:command] = s:GetDUBCommand(a:buffer)
-
-    if empty(l:command)
-        " If we can't run DUB, just run DMD.
-        return ale_linters#d#dmd#DMDCommand(a:buffer, [], {})
-    endif
-
-    return ale#command#Run(
-    \   a:buffer,
-    \   l:command,
-    \   function('ale_linters#d#dmd#DMDCommand'),
-    \   {'cwd': l:cwd},
-    \)
-endfunction
-
-function! ale_linters#d#dmd#DMDCommand(buffer, dub_output, meta) abort
-    let l:import_list = []
-    let l:str_import_list = []
-    let l:versions_list = []
-    let l:deb_versions_list = []
-    let l:list_ind = 1
-    let l:seen_line = 0
-
-    " Build a list of options generated from DUB, if available.
-    " DUB output each path or version on a single line.
-    " Each list is separated by a blank line.
-    " Empty list are represented by a blank line (followed and/or
-    " preceded by a separation blank line)
-    for l:line in a:dub_output
-        " line still has end of line char on windows
-        let l:line = substitute(l:line, '[\r\n]*$', '', '')
-
-        if !empty(l:line)
-            if l:list_ind == 1
-                call add(l:import_list, '-I' . ale#Escape(l:line))
-            elseif l:list_ind == 2
-                call add(l:str_import_list, '-J' . ale#Escape(l:line))
-            elseif l:list_ind == 3
-                call add(l:versions_list, '-version=' . ale#Escape(l:line))
-            elseif l:list_ind == 4
-                call add(l:deb_versions_list, '-debug=' . ale#Escape(l:line))
-            endif
-
-            let l:seen_line = 1
-        elseif !l:seen_line
-            " if list is empty must skip one empty line
-            let l:seen_line = 1
-        else
-            let l:seen_line = 0
-            let l:list_ind += 1
+        if !empty(l:dub_file)
+            return l:dub_file
         endif
     endfor
 
-    return 'dmd ' . join(l:import_list) . ' ' .
-    \   join(l:str_import_list) . ' ' .
-    \   join(l:versions_list) . ' ' .
-    \   join(l:deb_versions_list) . ' -o- -wi -vcolumns -c %t'
+    return ''
+endfunction
+
+function! ale_linters#d#dmd#DUBCommand(buffer) abort
+    " If we can't run dub, then skip this command.
+    if !executable('dub')
+        " Returning an empty string skips to the DMD command.
+        return ''
+    endif
+
+    let l:dub_file = s:FindDUBConfig(a:buffer)
+
+    if empty(l:dub_file)
+        return ''
+    endif
+
+    " To support older dub versions, we just change the directory to
+    " the directory where we found the dub config, and then run `dub describe`
+    " from that directory.
+    return 'cd ' . ale#Escape(fnamemodify(l:dub_file, ':h'))
+    \   . ' && dub describe --import-paths'
+endfunction
+
+function! ale_linters#d#dmd#DMDCommand(buffer, dub_output) abort
+    let l:import_list = []
+
+    " Build a list of import paths generated from DUB, if available.
+    for l:line in a:dub_output
+        if !empty(l:line)
+            " The arguments must be '-Ifilename', not '-I filename'
+            call add(l:import_list, '-I' . ale#Escape(l:line))
+        endif
+    endfor
+
+    return 'dmd '. join(l:import_list) . ' -o- -vcolumns -c %t'
 endfunction
 
 function! ale_linters#d#dmd#Handle(buffer, lines) abort
     " Matches patterns lines like the following:
     " /tmp/tmp.qclsa7qLP7/file.d(1): Error: function declaration without return type. (Note that constructors are always named 'this')
     " /tmp/tmp.G1L5xIizvB.d(8,8): Error: module weak_reference is in file 'dstruct/weak_reference.d' which cannot be read
-    let l:pattern = '\v^(\f+)\((\d+)(,(\d+))?\): (\w+): (.+)$'
+    let l:pattern = '^[^(]\+(\([0-9]\+\)\,\?\([0-9]*\)): \([^:]\+\): \(.\+\)'
     let l:output = []
-    let l:dir = expand('#' . a:buffer . ':p:h')
 
     for l:match in ale#util#GetMatches(a:lines, l:pattern)
-        " If dmd was invoked with relative path, match[1] is relative, otherwise it is absolute.
-        " As we invoke dmd with the buffer path (in /tmp), this will generally be absolute already
-        let l:fname = ale#path#GetAbsPath(l:dir, l:match[1])
         call add(l:output, {
-        \   'filename': l:fname,
-        \   'lnum': l:match[2],
-        \   'col': l:match[4],
-        \   'type': l:match[5] is# 'Warning' || l:match[5] is# 'Deprecation' ? 'W' : 'E',
-        \   'text': l:match[6],
+        \   'lnum': l:match[1],
+        \   'col': l:match[2],
+        \   'type': l:match[3] is# 'Warning' ? 'W' : 'E',
+        \   'text': l:match[4],
         \})
     endfor
 
@@ -110,7 +71,9 @@ endfunction
 call ale#linter#Define('d', {
 \   'name': 'dmd',
 \   'executable': 'dmd',
-\   'command': function('ale_linters#d#dmd#RunDUBCommand'),
+\   'command_chain': [
+\       {'callback': 'ale_linters#d#dmd#DUBCommand', 'output_stream': 'stdout'},
+\       {'callback': 'ale_linters#d#dmd#DMDCommand', 'output_stream': 'stderr'},
+\   ],
 \   'callback': 'ale_linters#d#dmd#Handle',
-\   'output_stream': 'stderr',
 \})

ale_linters/dafny/dafny.vim

@@ -1,41 +0,0 @@
-" Author: Taylor Blau <me@ttaylorr.com>
-
-function! ale_linters#dafny#dafny#Handle(buffer, lines) abort
-    let l:pattern = '\v(.*)\((\d+),(\d+)\): (.*): (.*)'
-    let l:output = []
-
-    for l:match in ale#util#GetMatches(a:lines, l:pattern)
-        call add(l:output, {
-        \    'filename': l:match[1],
-        \    'col': l:match[3] + 0,
-        \    'lnum': l:match[2] + 0,
-        \    'text': l:match[5],
-        \    'type': l:match[4] =~# '^Error' ? 'E' : 'W'
-        \ })
-    endfor
-
-    for l:match in ale#util#GetMatches(a:lines, '\v(.*)\((\d+),(\d+)\): (Verification of .{-} timed out after \d+ seconds)')
-        call add(l:output, {
-        \     'filename': l:match[1],
-        \     'col': l:match[3] + 0,
-        \     'lnum': l:match[2] + 0,
-        \     'text': l:match[4],
-        \     'type': 'E',
-        \ })
-    endfor
-
-    return l:output
-endfunction
-
-function! ale_linters#dafny#dafny#GetCommand(buffer) abort
-    return printf('dafny %%s /compile:0 /timeLimit:%d', ale#Var(a:buffer, 'dafny_dafny_timelimit'))
-endfunction
-
-call ale#Set('dafny_dafny_timelimit', 10)
-call ale#linter#Define('dafny', {
-\    'name': 'dafny',
-\    'executable': 'dafny',
-\    'command': function('ale_linters#dafny#dafny#GetCommand'),
-\    'callback': 'ale_linters#dafny#dafny#Handle',
-\    'lint_file': 1,
-\ })

ale_linters/dart/analysis_server.vim

@@ -1,29 +0,0 @@
-" Author: Nelson Yeung <nelsyeung@gmail.com>
-" Description: Check Dart files with dart analysis server LSP
-
-call ale#Set('dart_analysis_server_executable', 'dart')
-
-function! ale_linters#dart#analysis_server#GetProjectRoot(buffer) abort
-    " Note: pub only looks for pubspec.yaml, there's no point in adding
-    " support for pubspec.yml
-    let l:pubspec = ale#path#FindNearestFile(a:buffer, 'pubspec.yaml')
-
-    return !empty(l:pubspec) ? fnamemodify(l:pubspec, ':h:h') : '.'
-endfunction
-
-function! ale_linters#dart#analysis_server#GetCommand(buffer) abort
-    let l:executable = ale#Var(a:buffer, 'dart_analysis_server_executable')
-    let l:dart = resolve(exepath(l:executable))
-
-    return '%e '
-    \   . fnamemodify(l:dart, ':h') . '/snapshots/analysis_server.dart.snapshot'
-    \   . ' --lsp'
-endfunction
-
-call ale#linter#Define('dart', {
-\   'name': 'analysis_server',
-\   'lsp': 'stdio',
-\   'executable': {b -> ale#Var(b, 'dart_analysis_server_executable')},
-\   'command': function('ale_linters#dart#analysis_server#GetCommand'),
-\   'project_root': function('ale_linters#dart#analysis_server#GetProjectRoot'),
-\})

ale_linters/dart/dart_analyze.vim

@@ -1,29 +0,0 @@
-" Author: ghsang <gwonhyuksang@gmail.com>
-" Description: Check Dart files with dart analyze
-
-call ale#Set('dart_analyze_executable', 'dart')
-
-function! ale_linters#dart#dart_analyze#Handle(buffer, lines) abort
-    let l:pattern = '\v([a-z]+) - (.+):(\d+):(\d+) - (.+) - (.+)$'
-    let l:output = []
-
-    for l:match in ale#util#GetMatches(a:lines, l:pattern)
-        let [l:type, l:filename, l:lnum, l:col, l:message, l:code] = l:match[1:6]
-        call add(l:output, {
-        \   'type': l:type is# 'error' ? 'E' : l:type is# 'info' ? 'I' : 'W',
-        \   'text': l:code . ': ' . l:message,
-        \   'lnum': str2nr(l:lnum),
-        \   'col': str2nr(l:col),
-        \})
-    endfor
-
-    return l:output
-endfunction
-
-call ale#linter#Define('dart', {
-\   'name': 'dart_analyze',
-\   'executable': {b -> ale#Var(b, 'dart_analyze_executable')},
-\   'command': '%e analyze --fatal-infos %s',
-\   'callback': 'ale_linters#dart#dart_analyze#Handle',
-\   'lint_file': 1,
-\})

ale_linters/dart/dartanalyzer.vim

@@ -0,0 +1,40 @@
+" Author: w0rp <devw0rp@gmail.com>
+" Description: Check Dart files with dartanalyzer
+
+call ale#Set('dart_dartanalyzer_executable', 'dartanalyzer')
+
+function! ale_linters#dart#dartanalyzer#GetExecutable(buffer) abort
+    return ale#Var(a:buffer, 'dart_dartanalyzer_executable')
+endfunction
+
+function! ale_linters#dart#dartanalyzer#GetCommand(buffer) abort
+    let l:executable = ale_linters#dart#dartanalyzer#GetExecutable(a:buffer)
+    let l:path = ale#path#FindNearestFile(a:buffer, '.packages')
+
+    return ale#Escape(l:executable)
+    \   . (!empty(l:path) ? ' --packages ' . ale#Escape(l:path) : '')
+    \   . ' %t'
+endfunction
+
+function! ale_linters#dart#dartanalyzer#Handle(buffer, lines) abort
+    let l:pattern = '\v^  ([a-z]+) . (.+) at (.+):(\d+):(\d+) . (.+)$'
+    let l:output = []
+
+    for l:match in ale#util#GetMatches(a:lines, l:pattern)
+        call add(l:output, {
+        \   'type': l:match[1] is# 'error' ? 'E' : 'W',
+        \   'text': l:match[6] . ': ' . l:match[2],
+        \   'lnum': str2nr(l:match[4]),
+        \   'col': str2nr(l:match[5]),
+        \})
+    endfor
+
+    return l:output
+endfunction
+
+call ale#linter#Define('dart', {
+\   'name': 'dartanalyzer',
+\   'executable_callback': 'ale_linters#dart#dartanalyzer#GetExecutable',
+\   'command_callback': 'ale_linters#dart#dartanalyzer#GetCommand',
+\   'callback': 'ale_linters#dart#dartanalyzer#Handle',
+\})

ale_linters/dart/language_server.vim

@@ -1,20 +0,0 @@
-" Author: aurieh <me@aurieh.me>
-" Description: A language server for dart
-
-call ale#Set('dart_language_server_executable', 'dart_language_server')
-
-function! ale_linters#dart#language_server#GetProjectRoot(buffer) abort
-    " Note: pub only looks for pubspec.yaml, there's no point in adding
-    " support for pubspec.yml
-    let l:pubspec = ale#path#FindNearestFile(a:buffer, 'pubspec.yaml')
-
-    return !empty(l:pubspec) ? fnamemodify(l:pubspec, ':h:h') : ''
-endfunction
-
-call ale#linter#Define('dart', {
-\   'name': 'language_server',
-\   'lsp': 'stdio',
-\   'executable': {b -> ale#Var(b, 'dart_language_server_executable')},
-\   'command': '%e',
-\   'project_root': function('ale_linters#dart#language_server#GetProjectRoot'),
-\})

ale_linters/desktop/desktop_file_validate.vim

@@ -1,31 +0,0 @@
-call ale#Set('desktop_desktop_file_validate_options', '')
-
-" Example matches for pattern:
-"
-" foo.desktop: warning: key "TerminalOptions" in group ...
-" foo.desktop: error: action "new-private-window" is defined, ...
-let s:pattern = '\v^(.+): ([a-z]+): (.+)$'
-
-function! ale_linters#desktop#desktop_file_validate#Handle(buffer, lines) abort
-    " The error format doesn't specify lines, so we can just put all of the
-    " errors on line 1.
-    return ale#util#MapMatches(a:lines, s:pattern, {match -> {
-    \   'lnum': 1,
-    \   'col': 1,
-    \   'type': match[2] is? 'error' ? 'E' : 'W',
-    \   'text': match[3],
-    \}})
-endfunction
-
-call ale#linter#Define('desktop', {
-\   'name': 'desktop_file_validate',
-\   'aliases': ['desktop-file-validate'],
-\   'executable': 'desktop-file-validate',
-\   'command': {b ->
-\       '%e'
-\       . ale#Pad(ale#Var(b, 'desktop_desktop_file_validate_options'))
-\       . ' %t'
-\   },
-\   'callback': 'ale_linters#desktop#desktop_file_validate#Handle',
-\   'output_stream': 'both',
-\})

ale_linters/dockerfile/dockerfile_lint.vim

@@ -1,76 +0,0 @@
-" Author: Alexander Olofsson <alexander.olofsson@liu.se>
-
-call ale#Set('dockerfile_dockerfile_lint_executable', 'dockerfile_lint')
-call ale#Set('dockerfile_dockerfile_lint_options', '')
-
-function! ale_linters#dockerfile#dockerfile_lint#GetType(type) abort
-    if a:type is? 'error'
-        return 'E'
-    elseif a:type is? 'warn'
-        return 'W'
-    endif
-
-    return 'I'
-endfunction
-
-function! ale_linters#dockerfile#dockerfile_lint#Handle(buffer, lines) abort
-    try
-        let l:data = json_decode(join(a:lines, ''))
-    catch
-        return []
-    endtry
-
-    if empty(l:data)
-        " Should never happen, but it's better to be on the safe side
-        return []
-    endif
-
-    let l:messages = []
-
-    for l:type in ['error', 'warn', 'info']
-        for l:object in l:data[l:type]['data']
-            let l:line = get(l:object, 'line', -1)
-            let l:message = l:object['message']
-
-            let l:link = get(l:object, 'reference_url', '')
-
-            if type(l:link) == v:t_list
-                " Somehow, reference_url is returned as two-part list.
-                " Anchor markers in that list are sometimes duplicated.
-                " See https://github.com/projectatomic/dockerfile_lint/issues/134
-                let l:link = join(l:link, '')
-                let l:link = substitute(l:link, '##', '#', '')
-            endif
-
-            let l:detail = l:message
-
-            if get(l:object, 'description', 'None') isnot# 'None'
-                let l:detail .= "\n\n" . l:object['description']
-            endif
-
-            let l:detail .= "\n\n" . l:link
-
-            call add(l:messages, {
-            \   'lnum': l:line,
-            \   'text': l:message,
-            \   'type': ale_linters#dockerfile#dockerfile_lint#GetType(l:type),
-            \   'detail': l:detail,
-            \})
-        endfor
-    endfor
-
-    return l:messages
-endfunction
-
-function! ale_linters#dockerfile#dockerfile_lint#GetCommand(buffer) abort
-    return '%e' . ale#Pad(ale#Var(a:buffer, 'dockerfile_dockerfile_lint_options'))
-    \   . ' -p -j -f'
-    \   . ' %t'
-endfunction
-
-call ale#linter#Define('dockerfile', {
-\   'name': 'dockerfile_lint',
-\   'executable': {b -> ale#Var(b, 'dockerfile_dockerfile_lint_executable')},
-\   'command': function('ale_linters#dockerfile#dockerfile_lint#GetCommand'),
-\   'callback': 'ale_linters#dockerfile#dockerfile_lint#Handle',
-\})

ale_linters/dockerfile/hadolint.vim

@@ -2,72 +2,32 @@
 
 " always, yes, never
 call ale#Set('dockerfile_hadolint_use_docker', 'never')
-call ale#Set('dockerfile_hadolint_docker_image', 'hadolint/hadolint')
+call ale#Set('dockerfile_hadolint_docker_image', 'lukasmartinelli/hadolint')
 
 function! ale_linters#dockerfile#hadolint#Handle(buffer, lines) abort
     " Matches patterns line the following:
     "
-    " -:19 DL3001 warning: Pipe chain should start with a raw value.
-    " /dev/stdin:19:3 unexpected thing
-    let l:pattern = '\v^%(/dev/stdin|-):(\d+):?(\d+)? ((DL|SC)(\d+) )?((.+)?: )?(.+)$'
+    " stdin:19: F: Pipe chain should start with a raw value.
+    let l:pattern = '\v^/dev/stdin:?(\d+)? (\S+) (.+)$'
     let l:output = []
 
     for l:match in ale#util#GetMatches(a:lines, l:pattern)
         let l:lnum = 0
-        let l:colnum = 0
 
         if l:match[1] isnot# ''
             let l:lnum = l:match[1] + 0
         endif
 
-        if l:match[2] isnot# ''
-            let l:colnum = l:match[2] + 0
-        endif
+        let l:type = 'W'
+        let l:text = l:match[3]
 
-        " Shellcheck knows a 'style' severity - pin it to info level as well.
-        if l:match[7] is# 'style'
-            let l:type = 'I'
-        elseif l:match[7] is# 'info'
-            let l:type = 'I'
-        elseif l:match[7] is# 'warning'
-            let l:type = 'W'
-        else
-            let l:type = 'E'
-        endif
-
-        let l:text = l:match[8]
-        let l:detail = l:match[8]
-        let l:domain = 'https://github.com/hadolint/hadolint/wiki/'
-        let l:code = ''
-        let l:link = ''
-
-        if l:match[4] is# 'SC'
-            let l:domain = 'https://github.com/koalaman/shellcheck/wiki/'
-        endif
-
-        if l:match[5] isnot# ''
-            let l:code = l:match[4] . l:match[5]
-            let l:link = ' ( ' . l:domain . l:code . ' )'
-            let l:text = l:code . ': ' . l:detail
-            let l:detail = l:code . l:link . "\n\n" . l:detail
-        else
-            let l:type = 'E'
-            let l:detail = 'hadolint could not parse the file because of a syntax error.'
-        endif
-
-        let l:line_output = {
+        call add(l:output, {
         \   'lnum': l:lnum,
-        \   'col': l:colnum,
+        \   'col': 0,
         \   'type': l:type,
         \   'text': l:text,
-        \   'detail': l:detail
-        \}
-
-        if l:code isnot# ''
-            let l:line_output['code'] = l:code
-        endif
-
-        call add(l:output, l:line_output)
+        \   'nr': l:match[2],
+        \})
     endfor
 
     return l:output
@@ -102,21 +62,16 @@ endfunction
 
 function! ale_linters#dockerfile#hadolint#GetCommand(buffer) abort
     let l:command = ale_linters#dockerfile#hadolint#GetExecutable(a:buffer)
-    let l:opts = '--no-color -'
-
     if l:command is# 'docker'
-        return printf('docker run --rm -i %s hadolint %s',
-        \ ale#Var(a:buffer, 'dockerfile_hadolint_docker_image'),
-        \ l:opts)
+        return 'docker run --rm -i ' . ale#Var(a:buffer, 'dockerfile_hadolint_docker_image')
     endif
-
-    return 'hadolint ' . l:opts
+    return 'hadolint -'
 endfunction
 
 
 call ale#linter#Define('dockerfile', {
 \   'name': 'hadolint',
-\   'executable': function('ale_linters#dockerfile#hadolint#GetExecutable'),
-\   'command': function('ale_linters#dockerfile#hadolint#GetCommand'),
+\   'executable_callback': 'ale_linters#dockerfile#hadolint#GetExecutable',
+\   'command_callback': 'ale_linters#dockerfile#hadolint#GetCommand',
 \   'callback': 'ale_linters#dockerfile#hadolint#Handle',
 \})