jshaver
/
ale
forked from github-mirrors/ale
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

#653 Filter items based on the buffer number for problem counts

This commit is contained in:
w0rp 2017-08-13 13:24:10 +01:00
parent f67fc43d9b
commit ae6cecabb6
2 changed files with 49 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
autoload/ale/statusline.vim
View File

@ -22,10 +22,11 @@ function! ale#statusline#Update(buffer, loclist) abort
return return
endif endif
let l:loclist = filter(copy(a:loclist), 'v:val.bufnr == a:buffer')
let l:count = s:CreateCountDict() let l:count = s:CreateCountDict()
let l:count.total = len(a:loclist) let l:count.total = len(l:loclist)
for l:entry in a:loclist for l:entry in l:loclist
if l:entry.type is# 'W' if l:entry.type is# 'W'
if get(l:entry, 'sub_type', '') is# 'style' if get(l:entry, 'sub_type', '') is# 'style'
let l:count.style_warning += 1 let l:count.style_warning += 1

82
test/test_statusline.vader
View File

@ -31,7 +31,7 @@ After:
delfunction Counts delfunction Counts
Execute (Count should be 0 when data is empty): Execute (Count should be 0 when data is empty):
AssertEqual Counts({}), ale#statusline#Count(bufnr('%')) AssertEqual Counts({}), ale#statusline#Count(bufnr(''))
Execute (Count should read data from the cache): Execute (Count should read data from the cache):
let g:ale_buffer_info = {'44': {'count': Counts({'error': 1, 'warning': 2})}} let g:ale_buffer_info = {'44': {'count': Counts({'error': 1, 'warning': 2})}}
@ -44,23 +44,33 @@ Execute (The count should be correct after an update):
Execute (Count should be match the loclist): Execute (Count should be match the loclist):
let g:ale_buffer_info = { let g:ale_buffer_info = {
\ bufnr('%'): { \ bufnr(''): {
\ 'loclist': [ \ 'loclist': [
\ {'type': 'E'}, \ {'bufnr': bufnr('') - 1, 'type': 'E'},
\ {'type': 'E', 'sub_type': 'style'}, \ {'bufnr': bufnr('') - 1, 'type': 'E', 'sub_type': 'style'},
\ {'type': 'E', 'sub_type': 'style'}, \ {'bufnr': bufnr('') - 1, 'type': 'W'},
\ {'type': 'W'}, \ {'bufnr': bufnr('') - 1, 'type': 'W', 'sub_type': 'style'},
\ {'type': 'W'}, \ {'bufnr': bufnr('') - 1, 'type': 'I'},
\ {'type': 'W'}, \ {'bufnr': bufnr(''), 'type': 'E'},
\ {'type': 'W', 'sub_type': 'style'}, \ {'bufnr': bufnr(''), 'type': 'E', 'sub_type': 'style'},
\ {'type': 'W', 'sub_type': 'style'}, \ {'bufnr': bufnr(''), 'type': 'E', 'sub_type': 'style'},
\ {'type': 'W', 'sub_type': 'style'}, \ {'bufnr': bufnr(''), 'type': 'W'},
\ {'type': 'W', 'sub_type': 'style'}, \ {'bufnr': bufnr(''), 'type': 'W'},
\ {'type': 'I'}, \ {'bufnr': bufnr(''), 'type': 'W'},
\ {'type': 'I'}, \ {'bufnr': bufnr(''), 'type': 'W', 'sub_type': 'style'},
\ {'type': 'I'}, \ {'bufnr': bufnr(''), 'type': 'W', 'sub_type': 'style'},
\ {'type': 'I'}, \ {'bufnr': bufnr(''), 'type': 'W', 'sub_type': 'style'},
\ {'type': 'I'}, \ {'bufnr': bufnr(''), 'type': 'W', 'sub_type': 'style'},
\ {'bufnr': bufnr(''), 'type': 'I'},
\ {'bufnr': bufnr(''), 'type': 'I'},
\ {'bufnr': bufnr(''), 'type': 'I'},
\ {'bufnr': bufnr(''), 'type': 'I'},
\ {'bufnr': bufnr(''), 'type': 'I'},
\ {'bufnr': bufnr('') + 1, 'type': 'E'},
\ {'bufnr': bufnr('') + 1, 'type': 'E', 'sub_type': 'style'},
\ {'bufnr': bufnr('') + 1, 'type': 'W'},
\ {'bufnr': bufnr('') + 1, 'type': 'W', 'sub_type': 'style'},
\ {'bufnr': bufnr('') + 1, 'type': 'I'},
\ ], \ ],
\ }, \ },
\} \}
@ -73,46 +83,46 @@ Execute (Count should be match the loclist):
\ '0': 3, \ '0': 3,
\ '1': 12, \ '1': 12,
\ 'total': 15, \ 'total': 15,
\}, ale#statusline#Count(bufnr('%')) \}, ale#statusline#Count(bufnr(''))
Execute (Output should be empty for non-existant buffer): Execute (Output should be empty for non-existant buffer):
AssertEqual Counts({}), ale#statusline#Count(9001) AssertEqual Counts({}), ale#statusline#Count(9001)
Execute (Status() should return just errors for the old format): Execute (Status() should return just errors for the old format):
let g:ale_statusline_format = ['%sE', '%sW', 'OKIE'] let g:ale_statusline_format = ['%sE', '%sW', 'OKIE']
let g:ale_buffer_info = {bufnr('%'): {}} let g:ale_buffer_info = {bufnr(''): {}}
call ale#statusline#Update(bufnr('%'), [ call ale#statusline#Update(bufnr(''), [
\ {'type': 'E'}, \ {'bufnr': bufnr(''), 'type': 'E'},
\ {'type': 'E', 'sub_type': 'style'}, \ {'bufnr': bufnr(''), 'type': 'E', 'sub_type': 'style'},
\]) \])
AssertEqual '2E', ale#statusline#Status() AssertEqual '2E', ale#statusline#Status()
Execute (Status() should return just warnings for the old format): Execute (Status() should return just warnings for the old format):
let g:ale_statusline_format = ['%sE', '%sW', 'OKIE'] let g:ale_statusline_format = ['%sE', '%sW', 'OKIE']
let g:ale_buffer_info = {bufnr('%'): {}} let g:ale_buffer_info = {bufnr(''): {}}
call ale#statusline#Update(bufnr('%'), [ call ale#statusline#Update(bufnr(''), [
\ {'type': 'W'}, \ {'bufnr': bufnr(''), 'type': 'W'},
\ {'type': 'W', 'sub_type': 'style'}, \ {'bufnr': bufnr(''), 'type': 'W', 'sub_type': 'style'},
\ {'type': 'I'}, \ {'bufnr': bufnr(''), 'type': 'I'},
\]) \])
AssertEqual '3W', ale#statusline#Status() AssertEqual '3W', ale#statusline#Status()
Execute (Status() should return errors and warnings for the old format): Execute (Status() should return errors and warnings for the old format):
let g:ale_statusline_format = ['%sE', '%sW', 'OKIE'] let g:ale_statusline_format = ['%sE', '%sW', 'OKIE']
let g:ale_buffer_info = {bufnr('%'): {}} let g:ale_buffer_info = {bufnr(''): {}}
call ale#statusline#Update(bufnr('%'), [ call ale#statusline#Update(bufnr(''), [
\ {'type': 'E'}, \ {'bufnr': bufnr(''), 'type': 'E'},
\ {'type': 'E', 'sub_type': 'style'}, \ {'bufnr': bufnr(''), 'type': 'E', 'sub_type': 'style'},
\ {'type': 'W'}, \ {'bufnr': bufnr(''), 'type': 'W'},
\ {'type': 'W', 'sub_type': 'style'}, \ {'bufnr': bufnr(''), 'type': 'W', 'sub_type': 'style'},
\ {'type': 'I'}, \ {'bufnr': bufnr(''), 'type': 'I'},
\]) \])
AssertEqual '2E 3W', ale#statusline#Status() AssertEqual '2E 3W', ale#statusline#Status()
Execute (Status() should return the custom 'OK' string with the old format): Execute (Status() should return the custom 'OK' string with the old format):
let g:ale_statusline_format = ['%sE', '%sW', 'OKIE'] let g:ale_statusline_format = ['%sE', '%sW', 'OKIE']
let g:ale_buffer_info = {bufnr('%'): {}} let g:ale_buffer_info = {bufnr(''): {}}
call ale#statusline#Update(bufnr('%'), []) call ale#statusline#Update(bufnr(''), [])
AssertEqual 'OKIE', ale#statusline#Status() AssertEqual 'OKIE', ale#statusline#Status()
Execute(ale#statusline#Update shouldn't blow up when globals are undefined): Execute(ale#statusline#Update shouldn't blow up when globals are undefined):