Merge pull request #1999 from stevenharman/expand_filename_for_reek

Reek: --force-exclusion flag
This commit is contained in:
w0rp 2018-10-26 10:21:33 +01:00 committed by GitHub
commit adc914a675
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 7 deletions

View File

@ -30,7 +30,7 @@ function! ale_linters#ruby#reek#GetCommand(buffer, version_output) abort
\ : ''
return ale#handlers#ruby#EscapeExecutable(l:executable, 'reek')
\ . ' -f json --no-progress --no-color'
\ . ' -f json --no-progress --no-color --force-exclusion'
\ . l:display_name_args
endfunction

View File

@ -8,7 +8,7 @@ Execute(The reek callbacks should return the correct default values):
WithChainResults ['reek 5.0.0']
AssertLinter 'reek', [
\ ale#Escape('reek') . ' --version',
\ ale#Escape('reek') . ' -f json --no-progress --no-color --stdin-filename %s',
\ ale#Escape('reek') . ' -f json --no-progress --no-color --force-exclusion --stdin-filename %s',
\]
" Try with older versions.
@ -17,7 +17,7 @@ Execute(The reek callbacks should return the correct default values):
WithChainResults ['reek 4.8.2']
AssertLinter 'reek', [
\ ale#Escape('reek') . ' --version',
\ ale#Escape('reek') . ' -f json --no-progress --no-color',
\ ale#Escape('reek') . ' -f json --no-progress --no-color --force-exclusion',
\]
Execute(Setting bundle appends 'exec reek'):
@ -26,7 +26,7 @@ Execute(Setting bundle appends 'exec reek'):
WithChainResults ['reek 5.0.0']
AssertLinter 'bundle', ale#Escape('bundle')
\ . ' exec reek'
\ . ' -f json --no-progress --no-color --stdin-filename %s',
\ . ' -f json --no-progress --no-color --force-exclusion --stdin-filename %s',
" Try with older versions.
call ale#semver#ResetVersionCache()
@ -34,17 +34,17 @@ Execute(Setting bundle appends 'exec reek'):
WithChainResults ['reek 4.8.2']
AssertLinter 'bundle', ale#Escape('bundle')
\ . ' exec reek'
\ . ' -f json --no-progress --no-color'
\ . ' -f json --no-progress --no-color --force-exclusion'
Execute(The reek version check should be cached):
WithChainResults ['reek 5.0.0']
AssertLinter 'reek', [
\ ale#Escape('reek') . ' --version',
\ ale#Escape('reek') . ' -f json --no-progress --no-color --stdin-filename %s',
\ ale#Escape('reek') . ' -f json --no-progress --no-color --force-exclusion --stdin-filename %s',
\]
WithChainResults []
AssertLinter 'reek', [
\ '',
\ ale#Escape('reek') . ' -f json --no-progress --no-color --stdin-filename %s',
\ ale#Escape('reek') . ' -f json --no-progress --no-color --force-exclusion --stdin-filename %s',
\]