jshaver
/
ale
forked from github-mirrors/ale
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

#1751 Handle LSP completion results without the 'kind' attribute

This commit is contained in:
w0rp 2018-07-23 10:21:09 +01:00
parent 3e4db9ed5c
commit 7bf3a749d0
No known key found for this signature in database
GPG Key ID: 0FC1ECAA8C81CD83
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
autoload/ale/completion.vim
View File

@ -336,7 +336,9 @@ function! ale#completion#ParseLSPCompletions(response) abort
endif
" See :help complete-items for Vim completion kinds
if l:item.kind is s:LSP_COMPLETION_METHOD_KIND
if !has_key(l:item, 'kind')
let l:kind = 'v'
elseif l:item.kind is s:LSP_COMPLETION_METHOD_KIND
let l:kind = 'm'
elseif l:item.kind is s:LSP_COMPLETION_CONSTRUCTOR_KIND
let l:kind = 'm'

6
test/completion/test_lsp_completion_parsing.vader
View File

@ -430,10 +430,10 @@ Execute(Should handle Python completion results correctly):
\ }
\ })
Execute(Should handle missing detail keys):
Execute(Should handle missing keys):
AssertEqual
\ [
\ {'word': 'x', 'menu': '', 'info': 'y', 'kind': 'f', 'icase': 1},
\ {'word': 'x', 'menu': '', 'info': '', 'kind': 'v', 'icase': 1},
\ ],
\ ale#completion#ParseLSPCompletions({
\ 'jsonrpc': '2.0',
@ -443,8 +443,6 @@ Execute(Should handle missing detail keys):
\ 'items': [
\ {
\ 'label': 'x',
\ 'kind': 3,
\ 'documentation': 'y',
\ },
\ ]
\ }