Add tests for clangtidy with Makefile

ale_linters/c/clangtidy.vim

@@ -22,10 +22,9 @@ call ale#Set('c_build_dir', '')
 function! ale_linters#c#clangtidy#GetCommand(buffer, output) abort
     let l:checks = join(ale#Var(a:buffer, 'c_clangtidy_checks'), ',')
     let l:build_dir = ale#c#GetBuildDirectory(a:buffer)
-
-    " Get the extra options if we couldn't find a build directory.
     let l:options = ''
 
+    " Get the extra options if we couldn't find a build directory.
     if empty(l:build_dir)
         let l:options = ale#Var(a:buffer, 'c_clangtidy_options')
         let l:cflags = ale#c#GetCFlags(a:buffer, a:output)

ale_linters/cpp/clangtidy.vim

@@ -16,10 +16,9 @@ call ale#Set('c_build_dir', '')
 function! ale_linters#cpp#clangtidy#GetCommand(buffer, output) abort
     let l:checks = join(ale#Var(a:buffer, 'cpp_clangtidy_checks'), ',')
     let l:build_dir = ale#c#GetBuildDirectory(a:buffer)
-
-    " Get the extra options if we couldn't find a build directory.
     let l:options = ''
 
+    " Get the extra options if we couldn't find a build directory.
     if empty(l:build_dir)
         let l:options = ale#Var(a:buffer, 'cpp_clangtidy_options')
         let l:cflags = ale#c#GetCFlags(a:buffer, a:output)

test/command_callback/test_c_clang_tidy_command_callback.vader

@@ -1,4 +1,7 @@
 Before:
+  Save g:ale_c_parse_makefile
+  let g:ale_c_parse_makefile = 0
+
   call ale#assert#SetUpLinterTest('c', 'clangtidy')
   call ale#test#SetFilename('test.c')
 

test/command_callback/test_c_import_paths.vader

@@ -121,6 +121,16 @@ Execute(The C Clang handler should include root directories for projects with .h
   \   . ' -I' . ale#Escape(ale#path#Simplify(g:dir .  '/../test_c_projects/hpp_file_project'))
   \   . ' -'
 
+Execute(The C ClangTidy handler should include 'include' directories for projects with a Makefile):
+  call ale#assert#SetUpLinterTest('c', 'clangtidy')
+  call ale#test#SetFilename('../test_c_projects/makefile_project/subdir/file.cpp')
+  let g:ale_c_clangtidy_options = ''
+
+  AssertLinter 'clang-tidy',
+  \ ale#Escape('clang-tidy')
+  \ . ' %s '
+  \ . '-- -I' . ale#Escape(ale#path#Simplify(g:dir . '/../test_c_projects/makefile_project/include'))
+
 Execute(The C++ GCC handler should include 'include' directories for projects with a Makefile):
   call ale#assert#SetUpLinterTest('cpp', 'gcc')
   call ale#test#SetFilename('../test_c_projects/makefile_project/subdir/file.cpp')
@@ -225,3 +235,14 @@ Execute(The C++ ClangTidy handler should include json folders for projects with
   \ ale#Escape('clang-tidy')
   \   . ' %s '
   \   . '-p ' . ale#Escape(ale#path#Simplify(g:dir . '/../test_c_projects/json_project/build'))
+
+Execute(The C++ ClangTidy handler should include 'include' directories for projects with a Makefile):
+  call ale#assert#SetUpLinterTest('cpp', 'clangtidy')
+  call ale#test#SetFilename('../test_c_projects/makefile_project/subdir/file.cpp')
+  let g:ale_cpp_clangtidy_options = ''
+
+  AssertLinter 'clang-tidy',
+  \ ale#Escape('clang-tidy')
+  \ . ' %s '
+  \ . '-- -I' . ale#Escape(ale#path#Simplify(g:dir . '/../test_c_projects/makefile_project/include'))
+

test/command_callback/test_clang_tidy_command_callback.vader

@@ -1,4 +1,7 @@
 Before:
+  Save g:ale_c_parse_makefile
+  let g:ale_c_parse_makefile = 0
+
   call ale#assert#SetUpLinterTest('cpp', 'clangtidy')
   call ale#test#SetFilename('test.cpp')