Don't use a temporary file for tflint (#3717)

* Don't use a temporary file for tflint

* set cwd for tflint
This commit is contained in:
David Hotham 2021-05-25 01:41:14 +01:00 committed by GitHub
parent bf1c30f585
commit 3f386ae5e9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 5 deletions

View File

@ -91,7 +91,7 @@ function! ale_linters#terraform#tflint#GetCommand(buffer) abort
let l:cmd .= ' ' . l:opts
endif
let l:cmd .= ' -f json %t'
let l:cmd .= ' -f json'
return l:cmd
endfunction
@ -99,6 +99,7 @@ endfunction
call ale#linter#Define('terraform', {
\ 'name': 'tflint',
\ 'executable': {b -> ale#Var(b, 'terraform_tflint_executable')},
\ 'cwd': '%s:h',
\ 'command': function('ale_linters#terraform#tflint#GetCommand'),
\ 'callback': 'ale_linters#terraform#tflint#Handle',
\})

View File

@ -5,18 +5,18 @@ After:
call ale#assert#TearDownLinterTest()
Execute(The default command should be correct):
AssertLinter 'tflint', ale#Escape('tflint') . ' -f json %t'
AssertLinter 'tflint', ale#Escape('tflint') . ' -f json'
Execute(The default executable should be configurable):
let b:ale_terraform_tflint_executable = 'asdf'
AssertLinter 'asdf', ale#Escape('asdf') . ' -f json %t'
AssertLinter 'asdf', ale#Escape('asdf') . ' -f json'
Execute(Overriding options should work):
let g:ale_terraform_tflint_executable = 'fnord'
let g:ale_terraform_tflint_options = '--whatever'
AssertLinter 'fnord', ale#Escape('fnord') . ' --whatever -f json %t'
AssertLinter 'fnord', ale#Escape('fnord') . ' --whatever -f json'
Execute(Configuration files should be found):
call ale#test#SetFilename('../test-files/tflint/foo/bar.tf')
@ -25,4 +25,4 @@ Execute(Configuration files should be found):
\ ale#Escape('tflint')
\ . ' --config '
\ . ale#Escape(ale#path#Simplify(g:dir . '/../test-files/tflint/foo/.tflint.hcl'))
\ . ' -f json %t'
\ . ' -f json'